Signal-ios: New Image/Video Picker

Created on 17 Jul 2015  路  9Comments  路  Source: signalapp/Signal-iOS

  • [ ] Let users select multiple items
  • [ ] Let users review media selection before sending

Most helpful comment

I just want to emphasize on the importance of the image review before pressing send. Specially since a lot of journalist and typically at risk people use Signal, the cost of sending any wrong document or image to the wrong person because sender has accidentally tapped on them is extremely high.

All 9 comments

Suggestions:

  • [ ] Let users rotate images
  • [ ] Let users crop images
  • [ ] Let users attach a string to an image (i.e., a "caption").

I think we're conflating two things here:

  1. The first roughly corresponds to: https://github.com/WhisperSystems/Signal-iOS/issues/1132
  2. The second is about extra tools for the media picker, and sounds similar to how iOS Messages does media attachments:

image

I think this issue should just represent the second meaning, as the first has value in and of itself (and blocks paste functionality( #793 )).

I just want to emphasize on the importance of the image review before pressing send. Specially since a lot of journalist and typically at risk people use Signal, the cost of sending any wrong document or image to the wrong person because sender has accidentally tapped on them is extremely high.

Any progress on this? Once again, when trying to convince people to switch to signal, this was one of the problems a lot of them mentioned in the first days of usage.

Just started a bounty on this. Join in and pledge!
https://www.bountysource.com/issues/24517927-new-image-video-picker

@michaelkirk-signal I think this can be closed now.

@tzs1 cropping and rotating (as you would on Whatsapp) would still be a handy feature to have.

Those features are now available in beta 2.38.

For completeness to ensure that this has made it to the App Store, I can confirm that the following have all shipped to production in 2.38.1.2:

  • [x] Let users select multiple items
  • [x] Let users review media selection before sending
  • [x] Let users rotate images
  • [x] Let users crop images
  • [x] Let users attach a string to an image (i.e., a "caption")

so this can be closed.

nb: this includes the cropping and rotating you've suggested @samer

Was this page helpful?
0 / 5 - 0 ratings

Related issues

zero77 picture zero77  路  3Comments

andyggg picture andyggg  路  4Comments

michaelkirk picture michaelkirk  路  4Comments

mxmerz picture mxmerz  路  5Comments

zstal picture zstal  路  4Comments