Signal-desktop: Disappearing messages did not disappear

[denver-s]

• [x] I have searched open and closed issues for duplicates
  

---

Bug Description

Messages that supposed to be deleted are still visible on Signal Desktop (not on Signal iOS).

Steps to Reproduce

1. set disappearing messages timer to 6 hours
2. send message via iOS

Actual Result:

After 10 hours, when opening Signal Desktop, two messages are still visible.

Expected Result:

Messages should have been deleted.

Screenshots

As you can see they should last 6 hours, but they're 10 hours old!

Platform Info

Signal Version:

v1.31.0-beta.2

Operating System:

Windows 10

Linked Device Version:

iOS 13.3

Link to Debug Log

Messages are 1581403429192 and 1581403579948.

https://debuglogs.org/99311a2bf22694c0f03028bda7b0e2a3b4b4c83c7bd3c6434d49eee3a6a0241e

[josh-signal]

@denver-s thank you for the detailed bug report. The timestamp you're seeing on the messages (10h & 9h) are the times the messages were sent at. The disappearing timer begins once you read the message. Looking at 1581403579948 in the logs I see this event:

INFO  2020-02-11T16:37:29.602Z Set message expiration {"expiresAt":1581460649389,"sentAt":1581403579948}

which is setting expiration to 2020-02-11T22:37:29.389Z, 6 hours from when the message was processed as read. Can you please confirm if the message stayed unexpired past 22:37:29.389Z?

[NFM-8]

This seems like a consequence of the iOS issue https://github.com/signalapp/Signal-iOS/issues/4340

[denver-s]

@josh-signal I know that timer begings once I read, but why the other 10 messages sent by me and my friend did not show up? I thought the read time is somehow synchronized across devices.

[josh-signal]

@denver-s do you happen to have the message IDs for the messages that did disappear correctly?

[denver-s]

Unfortunately no.

[denver-s]

Happened again.
Yesterday (around 24 hours ago) I received and sent 4/5 messages with a contact with a disappearing timer of 6 hours. Everything was cleared on my iPhone, and on my desktop a single message did not disappear.

Debug log: https://debuglogs.org/de0e0fd5bfd952dbeac103aa5677df15746c4b98d034c6c5db83036e3498f272

Log says: Set message expiration {"expiresAt":1584473366295,"sentAt":1584372318109}
Which means expiration at 03/17/2020 @ 7:29pm (UTC)

Message ID: 1584372318109

Screenshot (you can see "lun 16:25" which means "monday 16:25"; today is tuesday):

[scottnonnenberg-signal]

@denver-s I dug into your log, and it looks as if the read sync for message 1584372318109 wasn't received, like it was for the messages around it. I'd like to send your Signal iOS log to the iOS folks, see if they have any ideas - can you provide it for us?

[denver-s]

Here it is: https://debuglogs.org/b6a50250ac9e72933734b7252a390f957dbca2d52a9639bf5ff875494486210b.zip

[scottnonnenberg-signal]

@denver-s Thanks. I've forwarded that log to the iOS folks, along with my analysis.

[denver-s]

@scottnonnenberg-signal It _seems_ that this issue has been fixed (Desktop v1.33.0-beta.4 / iOS 3.7.0.9).

[denver-s]

@scottnonnenberg-signal I'm sorry, but the problem persists (v1.34.0-beta.1)...

Timer: 6h
Multiple messages have been disappeared, but to this one (sent ID: 1587541484084 - 8h ago)
https://debuglogs.org/8c56870f1aa771b3dbdd4e93cc75a84f1b2738baa3c56a08c3210cfb616887d3

Same happens on another desktop (sent ID: 1587541484084 - v1.33.1)
https://debuglogs.org/f710529515bb4613c799aa49a534cc927a1b0106554ad3858b45d0533a27b31f

iOS (v3.8.0.32)
https://debuglogs.org/1531ef9ad8a5843954cf52a8250fa664c45d6853ce2616b72413735700c7d4bb.zip

[kenpowers-signal]

@denver-s it looks like the same thing, I don't see any read syncs for 1587541484084, but I do see that the message is set to expire in about six hours from now. The only thing I see in the iOS logs regarding that message are that it was received.

[kenpowers-signal]

@denver-s I just spoke with the iOS developers and they said that a fix should have been shipped already and will be investigating further.

[denver-s]

Might be a problem with the sender? I think, but I’m not sure, he’s on iOS (don’t know which version).

[kenpowers-signal]

If you read the version on your iOS device it should have sent a read sync to desktop. I'm not seeing that in the log.

[denver-s]

Oh ok, yes I read it on my iOS device.

[denver-s]

Bug is still occurring on v1.34.4-beta.1 and iOS 3.13.2

[josh-signal]

@denver-s can you please include your debug logs, the message ID, and also if we can please have the sender's debug logs as well it would help us paint a full picture on what's going on here.

[denver-s]

@scottnonnenberg-signal I'm sorry, but the problem persists (v1.34.0-beta.1)...

Timer: 6h
Multiple messages have been disappeared, but to this one (sent ID: 1587541484084 - 8h ago)
https://debuglogs.org/8c56870f1aa771b3dbdd4e93cc75a84f1b2738baa3c56a08c3210cfb616887d3

Same happens on another desktop (sent ID: 1587541484084 - v1.33.1)
https://debuglogs.org/f710529515bb4613c799aa49a534cc927a1b0106554ad3858b45d0533a27b31f

iOS (v3.8.0.32)
https://debuglogs.org/1531ef9ad8a5843954cf52a8250fa664c45d6853ce2616b72413735700c7d4bb.zip

I did it already

[denver-s]

Next time I encounter this problem I’ll ask my friend to send me a debug log.

[scottnonnenberg-signal]

@denver-s Yes new logs please. If you click the links for your previous logs, you can see that they've expired.

[denver-s]

OK so I've got this chat with a friend. Disappearing messages timer is set to 1 day.
This issue ALWAYS happens when I start Signal Desktop after a few days, after the messages should've been expired.

My Desktop v1.34.4-beta.1
Log: https://debuglogs.org/8373c253f9ab321b201591203974688d0a933208a5656dd449e4549be3dfd162

My iPhone 8 Plus - v3.13.2.6
Log: https://debuglogs.org/78f6c0e6cc10a08a8a5de58c72a109156a449a73bf0edf59caa6b21766aee815.zip

My friend's phone: iPhone X
Log: I've asked

Desktop screenshot
Today is tuesday 28/07/2020. Messages shown below were sent friday (_ven_) and saturday (_sab_).

In order:

• sent 1595612194819 received 1595867156010
• sent 1595613441290 received 1595867156347
• sent 1595691971502 received 1595867164916
• sent 1595691978071 received 1595867164917
• sent 1595691994492 received 1595867164917

[liufeijin]

I found this also, it is so danger . i sent and received messages will appear in signal on desktop ver.
Now i need login signal on desktop ver to delete all message, but i think it is not really deleted still , it can be found in your friend ID when they login signal on desktop. it is big problem. Signal has no safety at all.

[scottnonnenberg-signal]

@liufeijin We'll need more information before we can make progress in fixing your behavior. First, we need debug logs from your mobile device and your desktop instance. Then, we need the 'sent id' of a specific message that didn't disappear when it should have - the number next to the 'sent' timestamp in the message details screen. Then we can determine the details what went wrong. Thanks!

[denver-s]

@scottnonnenberg-signal did you look at my debug logs?

[scottnonnenberg-signal]

@denver-s Yes, from the logs it looked like your iOS device didn't send didn't send a 'read sync' for the message in question, and I reached out to the iOS folks.