Signal-desktop: net::ERR_NETWORK_CHANGED when opening laptop after moving locations

[colindean]

• [X] I have searched open and closed issues for duplicates

Possible previous issues: https://github.com/signalapp/Signal-Desktop/issues/1915 which leads to https://github.com/signalapp/Signal-Desktop/issues/1861, which this error seems to be related to interrupted downloads for any reason.

---

Bug Description

Upon opening my laptop at a new location, I get an error message with a scary dialog title of "Uncaught promise exception" or something like that:

Error: net::ERR_NETWORK_CHANGED
    at GenericProvider.getLatestVersion (/Applications/Signal.app/Contents/Resources/app.asar/node_modules/electron-updater/src/providers/GenericProvider.ts:18:25)
    at /Applications/Signal.app/Contents/Resources/app.asar/node_modules/electron-updater/src/AppUpdater.ts:347:26
    at Generator.next (<anonymous>)
    at runCallback (timers.js:696:18)
    at tryOnImmediate (timers.js:667:5)
    at processImmediate (timers.js:649:5)
From previous event:
    at MacUpdater.getUpdateInfoAndProvider (/Applications/Signal.app/Contents/Resources/app.asar/node_modules/electron-updater/src/AppUpdater.ts:336:43)
    at /Applications/Signal.app/Contents/Resources/app.asar/node_modules/electron-updater/src/AppUpdater.ts:363:31
    at Generator.next (<anonymous>)
From previous event:
    at MacUpdater.doCheckForUpdates (/Applications/Signal.app/Contents/Resources/app.asar/node_modules/electron-updater/src/AppUpdater.ts:360:34)
    at MacUpdater.checkForUpdates (/Applications/Signal.app/Contents/Resources/app.asar/node_modules/electron-updater/src/AppUpdater.ts:220:35)
    at Timeout.checkForUpdates [as _onTimeout] (/Applications/Signal.app/Contents/Resources/app.asar/app/auto_update.js:22:15)
    at ontimeout (timers.js:427:11)
    at tryOnTimeout (timers.js:289:5)
    at listOnTimeout (timers.js:252:5)
    at Timer.processTimers (timers.js:212:10)

Steps to Reproduce

1. Close Mac
2. Go to a different place on a different network
3. Open Mac
4. Wait until the dialog appears

Actual Result:

The above error will show.

Expected Result:

No exception should be uncaught.

Platform Info

Signal Version:

1.21.0

Operating System:

macOS 10.14.1

Linked Device Version:

Android, 4.32.8

Link to Debug Log

https://debuglogs.org/777cdb2683fa766dcfc572818f8822c66b40ae527aad489974710ccd862199d9

[benblank]

I'm having a very similar issue on Windows 10 after waking my computer from sleep. Since installing 1.21.0, waking the computer will sometimes cause Signal to open a modal with an "Unhandled Promise Rejection" for either net::ERR_NETWORK_CHANGED or net::ERR_NETWORK_IO_SUSPENDED. Closing the modal causes Signal to exit, requiring it to be restarted.

Link to Debug Log

https://debuglogs.org/a4cd48285401aa3f5adb69519b61b54d2d531b0c964ea07d86193c6a025f5ad5

[phybron]

Same issue on Windows 10 waking from sleep. Reading previous issues linked above I tested to see if switching VPN caused the issue, but it did not. Signal disconnected and reconnected fine. So it's only on wake from sleep.

Link to Debug Log

https://debuglogs.org/f22478e4e6ce4fd7e64f7654b7195c67b4ccd0401bd0c10c8e5680eed17314c5

[GeorgesPaul]

Same here on Windows 10. No issues when going to sleep and waking up when reconnecting to the same network/VPN after sleep. But yes issues when going to sleep and waking up at a different network.

I think I also noticed the error popping up randomly after a few hours of use. Will keen an eye on this, not sure about this last thing.

[phybron]

Now you mention it, I may have seen that too; crashing after a few hours of use without sleeping. Will keep an eye on it.

This is the first problem I've had with Signal desktop. I've been using it since it was a Chrome-based app.

[GeorgesPaul]

Now you mention it, I may have seen that too; crashing after a few hours of use without sleeping. Will keep an eye on it.

This is the first problem I've had with Signal desktop. I've been using it since it was a Chrome-based app.

Same here. Furthermore I also had this issue with 1.19.0

It may be a good idea to write a test for this scenario as a standard pre-release test. Anybody with a laptop will have this issue any time they open the laptop up. Apparently both Windows and Mac.

I'm slightly surprised that this went into production as I'm also not used to see such serious bugs in Signal. Especially (or maybe because?) since they got this money injection not long ago...

[scottnonnenberg-signal]

@GeorgesPaul Thanks for your concern! You might consider joining our Desktop beta program to ensure this kind of thing doesn't get into production, since these changes were in beta for about a week: https://github.com/signalapp/Signal-Desktop#install-the-beta

[scottnonnenberg-signal]

We expect this to be fixed by v1.21.1. Please let us know!

[GeorgesPaul]

@GeorgesPaul Thanks for your concern! You might consider joining our Desktop beta program to ensure this kind of thing doesn't get into production, since these changes were in beta for about a week: https://github.com/signalapp/Signal-Desktop#install-the-beta

Any chance the Beta could be released as a Chocolatey package (Chocolatey = a windows package manager)? The stable release is already in Chocolatey, but no Beta...

[phybron]

No problems since updating to v1.21.1.
Thanks!

[fleish]

@scottnonnenberg I just started experiencing this issue repeatedly while running 1.23.1 on macOS Sierra 10.12.6. It appears to be happening on every network change such as connecting or getting dropped from a VPN connection. If it matters, I am on a particularly unstable network (in-flight wifi) when it is happening and haven't experienced this issue until just now.