Sequel-ace: Query editor has white background when dark mode is enabled

Created on 1 Jul 2020  路  4Comments  路  Source: Sequel-Ace/Sequel-Ace

  • Sequel Ace Version: 2.1.0
  • macOS Version: 10.15.5
  • MySQL Version: 8.0.20

Description
Query editor has white background when dark mode is enabled
Screenshot 2020-07-01 at 10 43 47

Steps To Reproduce

  1. On Mac OS, enable dark mode (system preferences -> general -> Appearance -> dark)
  2. Open Sequel Ace, connect and go to Query Editor

Expected Behaviour
The query editor should have a dark background when dark mode is enabled, like Text Edit:

Light mode:
Screenshot 2020-07-01 at 10 45 07

Dark mode:
Screenshot 2020-07-01 at 10 44 45

Enhancement Low priority PR Welcome

Most helpful comment

@crstauf I think this can be done by extending themes to keep some "dark" flag and having dark / white theme pairs, or maybe there's better way. But currently core team is focused on fixing more important connection-, security- and stability-related bugs, that's why this issue is marked "PR Welcome" currently.

All 4 comments

@netojose This would be a nice enhancement to implement (specifying a dark mode theme that is different from the light mode one). The query editor is fully customizable theme-wise so please checkout Sequel Ace's preferences if you'd like a black-background query editor. There are multiple themes pre-loaded and you can customize your own.

@netojose This would be a nice enhancement to implement (specifying a dark mode theme that is different from the light mode one). The query editor is fully customizable theme-wise so please checkout Sequel Ace's preferences if you'd like a black-background query editor. There are multiple themes pre-loaded and you can customize your own.

Good @Jason-Morcos , I will see on preferences. Thanks!

@Jason-Morcos Will the query editor be adjusted to match the system color scheme, or is the use of themes the only option?

If a user has light and dark mode scheduled or automatic, going into Preferences and changing the theme twice each day (to match system color scheme) would be tiresome.

@crstauf I think this can be done by extending themes to keep some "dark" flag and having dark / white theme pairs, or maybe there's better way. But currently core team is focused on fixing more important connection-, security- and stability-related bugs, that's why this issue is marked "PR Welcome" currently.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ashatrov-realforce picture ashatrov-realforce  路  4Comments

stychos picture stychos  路  9Comments

SanderVanLeeuwen picture SanderVanLeeuwen  路  3Comments

augusl picture augusl  路  6Comments

gboudreau picture gboudreau  路  6Comments