Sensei: Course results title not working
https://github.com/Automattic/sensei/blob/master/includes/class-sensei-course-results.php#L56
The function should add "Course Results:" to the start of the page title on the course results page, but it doesn't appear to do anything.
danjjohnson
All 6 comments
Submitted a pull request :)
The code was using wp_title to modify the title which no longer being used in newer version of WordPress (>= 4.4)
Added document_title_parts to support newer version
It can be tested by switching between "Twenty Fourteen" theme (older version) and "Twenty Sixteen" theme (newer version)
ivantedja
on 8 Sep 2016
Thanks @ivantedja - we'll get this reviewed for the next release :)
danjjohnson
on 9 Sep 2016
I still don't see that in the title of the course results page:
Same in Twenty Twelve, Twenty Fourteen and Twenty Sixteen.
danjjohnson
on 16 Dec 2016
@danjohnson this function is used for altering the <title> html tag on <head>. It works as expected for me.
pgk
on 18 Dec 2016
@pgk ah sorry, I thought it was for the heading on the page :D
danjjohnson
on 18 Dec 2016
I think you have the wrong danjohnson :-)
On 18 Dec 2016, at 18:30, Dan Johnson notifications@github.com wrote:
@pgk ah sorry, I thought it was for the heading on the page :D
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
DanJohnson
on 18 Dec 2016
Related issues
gaurav1984
·
4Comments
Protohominid
·
6Comments
merkushin
·
3Comments
danjjohnson
·
5Comments
donnapep
·
5Comments
Most helpful comment
I think you have the wrong danjohnson :-)