Sensei: Possible issue with lesson excerpts

Created on 17 Feb 2016 · 7Comments · Source: Automattic/sensei

@dwainm you pushed a change here to simplify the excerpt on lessons:
https://github.com/woothemes/sensei/commit/b0cf4d52a80ff1f5e1a753d1c854d8f08cd46bca

I believe it was done that way before so that we could display the custom excerpt if there is one, or nothing if there isn't.

As I understand it the_excerpt will display an auto-generated excerpt if there is no custom excerpt provided.

I haven't had an issue with this in testing, but I've heard from a customer who is seeing an auto-excerpt (including messy shortcode content) on her lessons when logged out.

383646-zd-woothemes

[Pri] Low [Type] Bug

Source

danjjohnson

All 7 comments

I was able to replicate this issue when using Canvas, Hub, Mystile, or Superstore (the themes with Sensei integration.)

I assume those themes will need some template updates, but I wanted to add it here too for reference.

danjjohnson on 19 Feb 2016

Needs to be updated in those themes, but given the current priority internally I think we should make a note on each theme and take it from there.

dwainm on 15 Apr 2016

Reopening just so I don't forget about it.

danjjohnson on 18 Apr 2016

@dwainm can you advise on this? The issue also occurs in Definition, which does not have any specific Sensei integration, so I'm not sure that this is 100% a theme issue (although the themes with integration may also need updates).

If there is no custom excerpt on a lesson, the course page should not display an auto-excerpt for that lesson. It doesn't seem to be working like that currently (in some themes).

e.g.
Twenty Twelve - lesson does not show an auto-excerpt

Definition - lesson does show a custom excerpt

Any advice?

danjjohnson on 9 Jun 2016

@danjjohnson this is not a major issue, but our template definitely generates the excerpt. Maybe the logic for showing the excerpt should be revisited. So that it show nothing by default unless the user added an excerpt.

dwainm on 9 Jun 2016

👍1

Also the logic should look at if the user is taking the course.

dwainm on 9 Jun 2016

👍1

Definition is deprecated, but I couldn't reproduce using latest Storefront/Sensei. Will close for now