Secret-hitler: Unintentional Gamechat Autolock

[Max1071]

Some people are mentioning the gamechat locks on its own. They have to manually scroll down for each message.

[cozuya]

Yeah this incredibly irritating issue is a priority for me. Any reproduction steps would be awesome but I just need to work on it myself most likely. Actually its possible @andy013 has resolved it as I saw some changes to that area.

[andy013]

Yeah, I would like to see if the small changes I've made have fixed it. There are some other reasons it could be happening as well but I didn't want to make further changes before knowing if this fixed it or not.

Currently the way the scrollbar works is that whenever you scroll the lock is activated, but if you scroll to the bottom it is deactivated. The autoscroll on update will also trigger these events, so every time the chat updates the lock is being turned on but then immediately turned off as the chat has reached the bottom. Not ideal but I don't think there is a way to differentiate between manual and auto scrolling within perfect scrollbar. It seems to work for most people just fine but some people have this issue with the chat lock staying on. Hopefully it's nothing to do with this and the small fix I implemented will fix it, although I can't test it and will just need to wait and see. If not then we can try and rework the code a little to prevent this behaviour.

[Majstorr]

My chat still locks itself.

It will be unlocked, and then lock itself after about ~3-4 messages (seems to be right after a message as far as I can tell). From what you said about how the scrollbar lock works, the bug is that it doesn't unlock itself after scrolling down. When the bug happens, the chat automatically scrolls down to the new message, but then stays locked instead of unlocking itself. I use Chrome.

Hope that helps.

[andy013]

I think the update was just pushed tonight. Let us know if it's still happening in 10.2

[Majstorr]

It's still happening to me unfortunately, although feels like less frequently. Still happens right after a message. I tried disabling all my extensions and updating chrome; it didn't help. Might be something specific to my setup somehow, so if no one else is complaining don't worry about it.

Thanks for your time.

[andy013]

I think quite a few people have this issue. I had left some old code in the previous patch and after deleting it I wanted to see if that was the source of the problem or not so I didn't attempt any further fix. I have tried to change the code a little now so it should be fixed in the next update.

[cozuya]

Cool let me get this out the door tomorrow and we'll see. I've been a little lazy here.

[cozuya]

Just noticed direct dupe of (#398)