Scout: general report- pdf not working well

Created on 25 Jun 2020  路  32Comments  路  Source: Clinical-Genomics/scout

in fam 20101

the online page look like this (the table goes slightly outside the margin
bild

the pdf format is even worse. EDIT - try for yourself.

bug

All 32 comments

Can you supply browser version and operating system? Did you use any unusual screen or window size?

It looks good on my end, but that's also an N=1. 馃樃

Screenshot 2020-06-25 at 11 13 29

But, yeah, the pdf is not in a good state. At least a local lib issue. Let's check and see if it affects more reports, and if it persists in different envs. Thanks!

It is perhaps not my place to make the judgement between patient confidentiality and urgency of this issue, but may I suggest again that you provide either a toy example or send reports such as this, that lean more towards the Solna instance, as tickets to the support system. This is free to read for all of Internet.

good point!!!!
thanks
How can I remove the pdf?

Fixed! 馃槉

(There are like three little dots on the top right of the messages. They trigger a dropdown. Select edit from that, and you can change your post.)

the browser is Firefox, no idea how to check version
Window 7 operating system

PDF version looks ugly also on Chrome. I strongly suspect it's this long list of genes, separated by commas but no space that might be causing it.

image

Generally you will find versions on GUI tools by selecting the "About" menu item. LabIT can help you upgrade if you have been left behind on updates (mine is on 77.0.1). I know someone @ klingen (HM?) had an issue with her Firefox not beeing kept up to date. Leave an issue in Navet, or go find your friendly neighbour sysadmin.

And yeah, I think you are right @northwestwitch; the minimum width calculation could be based on word wrapping and not deal with long strings. Probably that then allows the family info to escape its bounding box, and not wrap on the "-" in the individual ids since there is suddenly some other item further to the right. That could definitely happen in latex, and I suspect the layout algorithm is similar: who wouldn't copy Knuth?

and I suspect the layout algorithm is similar: who wouldn't copy Knuth?

I don't know the guy but in that case the fix is easy!

Right - fingers crossed!

No me neither, but his craft is solid. Still going strong at 10001 base 3 with updating his The Art of Computer Programming (https://sv.m.wikipedia.org/wiki/The_Art_of_Computer_Programming) it seems, although nowadays more people refer to StackOverflow than it. 馃槃

nowadays more people refer to StackOverflow than it

Yeah I wonder why.. 馃槅 Anyway, the only complicated thing is to understand where to introduces spaces in users comment whenever they write a stream of consciousness.. I'll try to fix something

StackOverflow lists e.g. CSS "word-wrap: break-word;" and "overflow-wrap: break-word". I suppose the question becomes which ones the pdf renderer (and possibly our favourite browsers) support?

I was thinking introduce a space after every comma, whenever the space is missing. That way the text gets distributed over multiple lines. The only situation this is not working is where there is a super long unique word non separated by spaces

The problem I'm seeing in the code is that we have to fix not only the comments from cases, but also those from the variants, because the same thing could happen there as well.

Yep. If the text areas would get either of those classes in css, at least for the reports, that might be it, conditions as above.

https://www.techrepublic.com/blog/web-designer/css3-new-properties-for-text-overflow-and-text-wrap/

"Word-wrap is probably not going to be the most widely used CSS3 property but it definitely has a practical use, for example, in controlling the styling of comment sections within blog posts or forms."

I've drafted a fix, jinja-style

https://www.techrepublic.com/blog/web-designer/css3-new-properties-for-text-overflow-and-text-wrap/

I'm open to this solution as long as it doesn't cut the words in the sentence

I noticed while testing out that also the regular layout is somewhat sensitive to this. Try adding a very long word into comment boxes etc. cringe

also the regular layout is somewhat sensitive to this

I know, I was pretending everything was fine! 馃槃

bootstrap has a class text-break that deals with this (adding browser specific word-break css)
https://getbootstrap.com/docs/4.3/utilities/text/#word-break

One could just add text-break to the comment displaying boxes, and be done?

Yes, let's try!

Looks like the text-break works fine!
image

Yes, it works like a charm for the main pages. And the comments box is just one component in the global utils, so a one-liner. Then there's the report.

Before:
Screenshot 2020-06-25 at 15 03 02
After:
Screenshot 2020-06-25 at 15 03 12
馃槃

Yes!
Screenshot 2020-06-25 at 15 08 22

I bet who writes a comment like that @dnil would also have a diagnosis..

馃ぃ Most likely..

And thanks - I really like this way better! Starting to edit the input feels a little risky. This will be nicely supportive of different screen sizes, long words and what not.

I really like this way better!

Me too! Thank you!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

heronikdin picture heronikdin  路  4Comments

hassanfa picture hassanfa  路  4Comments

hassanfa picture hassanfa  路  3Comments

ViktorHy picture ViktorHy  路  4Comments

heronikdin picture heronikdin  路  4Comments