Rss-bridge: No app.json found in Heroku

[codeinteger6]

Describe the bug
When using the Heroku deploy button, it fails saying no app.json found (even though the repo itself has an app.json file)

To Reproduce
Steps to reproduce the behavior:

1. Click the Heroku deploy button found on the readme
2. Type app name then press Deploy
3. See error

Expected behavior
It should deploy instead of giving this error.

Screenshots

Desktop

• OS: Windows 10 Build 18362.175
• Browser: Google Chrome
• Version: 75.0.3770.80 (Official Build) (64-bit)

[LogMANOriginal]

Thanks for the feedback, highly appreciated.
Ping @azdkj532

Could this line be the issue?
https://github.com/RSS-Bridge/rss-bridge/blob/de53120843c977a000760e3c4e8e205d71e7a162/app.json#L2

[azdkj532]

I found something strange in build log after commit b74dda7, maybe this is the reason that Heroku cannot fetch app.json.

-----> PHP app detected
 !     WARNING: No 'composer.json' found!
 !     
 !     Your project only contains an 'index.php', no 'composer.json'.
 !     
 !     Using 'index.php' to declare app type as PHP is deprecated and
 !     may lead to unexpected behavior.
 !    
 !     Please consider updating your codebase to utilize Composer and
 !     modern dependency management in order to benefit from the latest
 !     PHP runtimes and improved application performance, as well as
 !     control over the PHP versions and extensions available.
 !     
 !     For an introduction to dependency management with Composer and
 !     how to get the most out of PHP on Heroku, refer to the docs at
 !     https://getcomposer.org/doc/00-intro.md and
 !     https://devcenter.heroku.com/articles/getting-started-with-php
-----> Bootstrapping...
-----> Installing platform packages...
       NOTICE: No runtime required in composer.lock; using PHP ^7.0.0
       - php (7.3.6)
       - apache (2.4.39)
       - nginx (1.16.0)
-----> Installing dependencies...

[LogMANOriginal]

I see what's going on. They do git archive ... or something similar when pulling the repository, which takes the file .gitattributes into consideration. If they did a shallow clone and local export, this wouldn't be an issue. They should really improve their service for maintainability.

The only thing we can do is to keep app.json in every release. Not optimal, but most people probably don't care and the file is not harmful anyway.

Edit: This probably also includes the composer files...

[LogMANOriginal]

Should be fixed. Please try again.

[codeinteger6]

It’s working now, thank you!