Rss-bridge: "whitelist" is in fact "excludelist"

[chankalan]

Is your feature request related to a problem? Please describe.
The terminology of "whitelist.txt" doesn't reflect what the list is...
Related to this topic : https://wiki.php.net/rfc/change-terminology-to-excludelist

Describe the solution you'd like
Should "includelist.txt" be better ?

Do you think it's worth changing it ? For me, yes it is.

Thanks for the bridge !

[em92]

There are also related discussions:
https://github.com/php/php-src/pull/5685
https://externals.io/message/110582

Didn't read all the discussion, but I agree with Arvids Godjuks's comment: https://externals.io/message/110582#110671

In short, "includelist" in Russian will be translated by human as "белый список" which is literally "white list".

[em92]

Also suggesting to change theme from:

"whitelist" is in fact "excludelist"

to

"whitelist" is in fact "includelist"

[em92]

In short, "includelist" in Russian will be translated by human as "белый список" which is literally "white list".

Forgot to say, that in Russia "белый список" is not related to white people and is not racist.

[Nono-m0le]

AllowList seems more correct and recently adopted by the Kernel Mainteners/Linux team ( see https://lkml.org/lkml/2020/7/4/229 )

[chankalan]

@em92 : the discussion you told about links to https://github.com/php/php-src/pull/5685#issuecomment-641157299
This post is lightening me...

[em92]

@chankalan I see. In any case, if someone changes "whitelist" to anything else, there should be backward compatibility when instance admin is using "whitelist.txt" to define enabled bridges.

[mitsukarenai]

Just popping in, with some thoughts ^-^
One side effect when I chose "whitelist.txt" as filename (back in 2014, wow!) is that by alphabetic order, that file would be at the end of file listings.

But with this being a little bit of convenience, I feel it also comes with a bit of confusion for who didn't read the documentation first (let's face it: I'm also a kinda "install and run first, read doc later" person). What is being "whitelisted"? Bridges? IP addresses? RSS clients? Output formats? Input parameters?
Once opening the default template, the role of that file becomes more clear. But still, the terminology could be more explicit.

So, how to address this AND still profit from alphabetical ordering ease of access?
Here a couple options I found: ActivatedBridges.txt, AllowedBridges.txt, UnlockedBridges.txt

And for retro-compatibility, I'd see two options:

• keep and use existing "whitelist.txt" if present (conservation, risk of code debt)
• rename existing "whitelist.txt" if present (upgrading, risk of admin confusion)

[chankalan]

Yes, it seems quite right.
Maybe the first option ?... I don't know...