Retroarch: iOS Build is broken since 17/05 or 18/05 changes, crash at launch

[Alex793]

All is in the title.

My compiled build from the 16th and before was ok on my iPad's iOS 9.3.3 and 10.2 but yesterday and today I tried to compile a new one with last change but crash at launch on my two iPad.

No error on compilation, sign etc.

I think the problem is in the recent change because no problem when I compile a build before this date (have some backups).

Date/Time:           2017-05-19 07:59:36.36 +0200
Launch Time:         2017-05-19 07:59:35.35 +0200
OS Version:          iOS 9.3.3 (13G34)
Report Version:      105

Exception Type:  EXC_BAD_ACCESS (SIGSEGV)
Exception Subtype: KERN_INVALID_ADDRESS at 0x0000000000000025
Triggered by Thread:  0

Filtered syslog:
None found

Thread 0 name:  Dispatch queue: com.apple.main-thread
Thread 0 Crashed:
0   RetroArch                       0x0010158e menu_driver_toggle (menu_driver.c:252)
1   RetroArch                       0x00101581 menu_driver_toggle (menu_driver.c:251)
2   RetroArch                       0x000444e7 menu_driver_ctl (menu_driver.c:651)
3   RetroArch                       0x00069999 rarch_menu_running_finished (retroarch.c:1319)
4   RetroArch                       0x0001354d rarch_disable_ui (ui_cocoatouch.m:71)
5   RetroArch                       0x00013519 -[RetroArch_iOS showGameView] (ui_cocoatouch.m:453)
6   RetroArch                       0x0001297f -[RetroArch_iOS applicationDidFinishLaunching:] (ui_cocoatouch.m:362)
7   UIKit                           0x268e7b09 -[UIApplication _handleDelegateCallbacksWithOptions:isSuspended:restoreState:] + 549
8   UIKit                           0x26b1183f -[UIApplication _callInitializationDelegatesForMainScene:transitionContext:] + 4551
9   UIKit                           0x26b15241 -[UIApplication _runWithMainScene:transitionContext:completion:] + 1589
10  UIKit                           0x26b29811 __84-[UIApplication _handleApplicationActivationWithScene:transitionContext:completion:]_block_invoke3286 + 37
11  UIKit                           0x26b12767 -[UIApplication workspaceDidEndTransaction:] + 135
12  FrontBoardServices              0x23967bf7 __FBSSERIALQUEUE_IS_CALLING_OUT_TO_A_BLOCK__ + 19
13  FrontBoardServices              0x23967aa7 -[FBSSerialQueue _performNext] + 227
14  FrontBoardServices              0x23967da5 -[FBSSerialQueue _performNextFromRunLoopSource] + 45
15  CoreFoundation                  0x2225b9e7 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 15
16  CoreFoundation                  0x2225b5d7 __CFRunLoopDoSources0 + 455
17  CoreFoundation                  0x2225993f __CFRunLoopRun + 807
18  CoreFoundation                  0x221a81c9 CFRunLoopRunSpecific + 517
19  CoreFoundation                  0x221a7fbd CFRunLoopRunInMode + 109
20  UIKit                           0x268e0f37 -[UIApplication _run] + 527
21  UIKit                           0x268db435 UIApplicationMain + 145
22  RetroArch                       0x00013f7d main (ui_cocoatouch.m:544)
23  libdyld.dylib                   0x21e54873 start + 3

Thread 1:
0   libsystem_kernel.dylib          0x21f28864 __workq_kernreturn + 8
1   libsystem_pthread.dylib         0x21fcae19 _pthread_wqthread + 1037
2   libsystem_pthread.dylib         0x21fca9fc start_wqthread + 8

Thread 2 name:  Dispatch queue: com.apple.libdispatch-manager
Thread 2:
0   libsystem_kernel.dylib          0x21f292f8 kevent_qos + 24
1   libdispatch.dylib               0x21e3b837 _dispatch_mgr_invoke + 255
2   libdispatch.dylib               0x21e2d917 _dispatch_mgr_thread + 39

Thread 3:
0   libsystem_kernel.dylib          0x21f28864 __workq_kernreturn + 8
1   libsystem_pthread.dylib         0x21fcae19 _pthread_wqthread + 1037
2   libsystem_pthread.dylib         0x21fca9fc start_wqthread + 8

Thread 4:
0   libsystem_kernel.dylib          0x21f28864 __workq_kernreturn + 8
1   libsystem_pthread.dylib         0x21fcae19 _pthread_wqthread + 1037
2   libsystem_pthread.dylib         0x21fca9fc start_wqthread + 8

Thread 5:
0   libsystem_kernel.dylib          0x21f28864 __workq_kernreturn + 8
1   libsystem_pthread.dylib         0x21fcae19 _pthread_wqthread + 1037
2   libsystem_pthread.dylib         0x21fca9fc start_wqthread + 8

Thread 6 name:  AVAudioSession Notify Thread
Thread 6:
0   libsystem_kernel.dylib          0x21f138a8 mach_msg_trap + 20
1   libsystem_kernel.dylib          0x21f136a9 mach_msg + 41
2   CoreFoundation                  0x2225b6ad __CFRunLoopServiceMachPort + 137
3   CoreFoundation                  0x22259a33 __CFRunLoopRun + 1051
4   CoreFoundation                  0x221a81c9 CFRunLoopRunSpecific + 517
5   CoreFoundation                  0x221a7fbd CFRunLoopRunInMode + 109
6   libAVFAudio.dylib               0x27bd1257 GenericRunLoopThread::Entry(void*) + 135
7   libAVFAudio.dylib               0x27ba6047 CAPThread::Entry(CAPThread*) + 155
8   libsystem_pthread.dylib         0x21fccc7f _pthread_body + 139
9   libsystem_pthread.dylib         0x21fccbf3 _pthread_start + 111
10  libsystem_pthread.dylib         0x21fcaa08 thread_start + 8

Thread 0 crashed with ARM Thread State (32-bit):
    r0: 0x00000000    r1: 0x00276db0      r2: 0xb2f380f1      r3: 0x00003fff
    r4: 0x272bfbde    r5: 0x00730020      r6: 0x00000000      r7: 0x0056643c
    r8: 0x0000000c    r9: 0x0184bb48     r10: 0x00000000     r11: 0x00730090
    ip: 0x27003299    sp: 0x00566404      lr: 0x00101581      pc: 0x0010158e
  cpsr: 0x40000030

[ghost]

This PR #4940 solves crash under Windows, maybe will help on iOS too.

[Alex793]

Thanks for the info, let you know when at home :+1:

Edit : Arf nope, still crash at launch on iOS, I'll try to check all commits between the 16th and the 18th.

[twinaphex]

See if this fixes the issues -

https://github.com/libretro/RetroArch/commit/e42ed3e3df49777c55f8b66c61bee84ab227494c

It fixed two crashes for me here when starting up the iOS build for the first time.

[Alex793]

Nice, it works now, thanks 👍

[iOS4all]

@Alex793 please can you give me the compile build of retroarch.
I was waiting for this.
Thanks