Renovate: Renovate appends the docker digest twice

Created on 23 Apr 2020  路  6Comments  路  Source: renovatebot/renovate

What Renovate type are you using?
Reproducible with

  • GitHub App
  • Selfhosted v19.216.6

Describe the bug
Renovate appends the docker digest twice in a gitlab-ci.yml:

image: node:12@sha256:44d3b16983346c5f48b27de2f52301d8dca64698c2680764d77198d81d9d1dc8@sha256:44d3b16983346c5f48b27de2f52301d8dca64698c2680764d77198d81d9d1dc8

There is another row in the file that should receive a digest pin, maybe somehow renovates inserts this pin to the wrong place.

Did you see anything helpful in debug logs?
no

To Reproduce
The error can be seen in Repo https://github.com/schuch/renovate-6033 in Pull Request
https://github.com/schuch/renovate-6033/pull/3/files

gitlab-ci bug

Most helpful comment

This should now be resolved, as per this forked reproduction: https://github.com/renovate-tests/renovate-6033/pull/2/files

All 6 comments

The first digest pin was appended in https://github.com/schuch/renovate-6015/pull/15/files
In this PR renovate also missed the second digest pin in line 11

Which release/version of Renovate was this tested against?

Also, can you add a description in the readme for the reproduction repo? It's a little confusing knowing what's going on as there are three Dockerfiles and 5 PRs

Which release/version of Renovate was this tested against?

We encountered the error with Selfhosted v19.216.6

Also, can you add a description in the readme for the reproduction repo? It's a little confusing knowing what's going on as there are three Dockerfiles and 5 PRs

Sorry for the mess. I was in the process of reproducing another bug when this came up.
I will extract this reproduction to a separate repo get rid of the noise.

Raised repo https://github.com/schuch/renovate-6033

In PR https://github.com/schuch/renovate-6033/pull/2 (a pin digest PR) you can see, that renovate misses to update the second image reference.

This could be the related to the duplicated docker digest, that follows in PR https://github.com/schuch/renovate-6033/pull/3

This should now be resolved, as per this forked reproduction: https://github.com/renovate-tests/renovate-6033/pull/2/files

Was this page helpful?
0 / 5 - 0 ratings