Renovate: Yarn.lock file is almost never updated in dependency update PRs

Created on 27 Jun 2018  路  4Comments  路  Source: renovatebot/renovate

What Renovate type are you using?
Renovate GitHub App

Describe the bug
We have a repository using yarn workspaces (but not lerna) with the following config:

  "workspaces": [
    "packages/*",
    "app/"
  ],
  "renovate": {
    "extends": ["config:base"],
    "semanticPrefix": "chore:",
    "lockFileMaintenance": {
      "enabled": true
    },
    "updateLockFiles": true,
    "prCreation": "not-pending",
    "packageRules": [
      {
        "packagePatterns": ["^@types/"],
        "automerge": true
      }
    ]
  },

Most PRs only change the dependency version in the package.json.
By looking at the recently closed PRs we can see that only one has an updated yarn.lock as well:

Expected behavior
Every update PR should have an updated lock file as well.

Additional context
I looked at the related issues: #1654 and #2108 - The first one doesn't seem likely as the lock files in our PRs only get updated once in about every 20 PRs or so. The other issue might be related - but we are not using lerna as we are building an application and not publishable packages.

npm priority-2-important bug

All 4 comments

Thanks for raising the issue. It doesn鈥檛 sound like the same problem as previous issues. I鈥檒l look into it soon to determine what鈥檚 going wrong.

:tada: This issue has been resolved in version 13.0.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Wow, thank you for such quick work!

@ZauberNerd you're welcome, and thanks for the detailed bug report that helped me track it down easily.

FYI, the problem was with the app/package.json only - lock files were being updated fine for the rest. More specifically, we were failing to match it to the "app/" pattern in your workspaces array as minimatch seemed to want an exact match or a /* pattern to match it. I tested it against a fork of your repo to verify it and it's now live in the app, so future PRs should hopefully be all fine for you.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Siilwyn picture Siilwyn  路  4Comments

ChristianMurphy picture ChristianMurphy  路  4Comments

jgarec picture jgarec  路  3Comments

zephraph picture zephraph  路  3Comments

Flydiverny picture Flydiverny  路  4Comments