Renovate: Bug: unnecessarily escaped @'s in changelogs

Created on 13 Jul 2018  路  4Comments  路  Source: renovatebot/renovate

What Renovate type are you using?
Renovate GitHub App

Describe the bug

Added: stylelint-config-recommended@​2.1.0 as dependency

Notice the ​

Additional context
Please see https://github.com/pymedusa/Medusa/pull/4619

priority-4-low bug
Source
picture OmgImAlexis

Most helpful comment

We need to aggressively escape @鈥榮 to make sure we don鈥檛 accidentally trigger GitHub鈥檚 auto linking. In this case it鈥檚 not necessary however to know that we鈥檇 probably need to be fully markdown-aware, which would be very complex.

picture rarkins on 13 Jul 2018
👍2

All 4 comments

@OmgImAlexis I looked at the PR and don't understand what I'm meant to be looking for. Can you give more details?

rarkins picture rarkins on 13 Jul 2018

Look at the changelog under v18.2.0.

The original changelog
screen shot 2018-07-13 at 2 14 45 pm

What renovate added to the PR.
screen shot 2018-07-13 at 2 14 41 pm

OmgImAlexis picture OmgImAlexis on 13 Jul 2018

We need to aggressively escape @鈥榮 to make sure we don鈥檛 accidentally trigger GitHub鈥檚 auto linking. In this case it鈥檚 not necessary however to know that we鈥檇 probably need to be fully markdown-aware, which would be very complex.

rarkins picture rarkins on 13 Jul 2018
👍2

This particular case/example is now fixed, but it's a neverending whack-a-mole.

image

rarkins picture rarkins on 22 Sep 2018
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

grzesuav picture grzesuav  路  3Comments
rarkins picture rarkins  路  3Comments
ChristianMurphy picture ChristianMurphy  路  4Comments
rarkins picture rarkins  路  4Comments
Flydiverny picture Flydiverny  路  4Comments