Renovate: Ignore engines that aren't in NPM

Created on 1 Jun 2018  路  4Comments  路  Source: renovatebot/renovate

What Renovate type are you using?
Renovate GitHub App

Describe the bug
Renovate is attempting to keep the engines field "updated" for values that aren't in NPM, leading to it filing PR's that remove parts of the range for some reason (https://github.com/ChristianMurphy/linter-selective/pull/29).

To Reproduce
Steps to reproduce the behavior:

  1. Create repository with an engines field that isn't in NPM (such as atom)
  2. Watch Renovate attempt to break the version range specified

Expected behavior
engines values that aren't in NPM should be ignored.

Screenshots
N/A.

Additional context
This functionality seems to be being requested in https://github.com/renovateapp/renovate/issues/320 and is partially implemented.

priority-2-important bug

Most helpful comment

I decided to just whitelist npm, node and yarn fields in engines and skip the rest. I pushed a commit just now for that, so thanks for reporting the bug and sorry for the inconvenience caused!

All 4 comments

There is a package atom on npmjs ([email protected]) so isn't it technically "in NPM"?

Anyway, for now I will apply a whitelisting and only look at node, npm, and yarn.

There is a package atom on npmjs ([email protected]) so isn't it technically "in NPM"?

Oh wow, that does complicate things on your end!

I decided to just whitelist npm, node and yarn fields in engines and skip the rest. I pushed a commit just now for that, so thanks for reporting the bug and sorry for the inconvenience caused!

:tada: This issue has been resolved in version 12.39.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Was this page helpful?
0 / 5 - 0 ratings