Renovate: Incorrect major version resolution for org.clojure:clojurescript 0.0-1552

[mkarp]

What Renovate type are you using?
Renovate GitHub App

Describe the bug
Hey there!

Renovate keeps opening pull requests to update org.clojure:clojurescript despite us having the latest version already. Latest stable version is 1.10.520. Renovate would keep opening pull requests for old prerelease versions (for example, 0.0-1552).

What's interesting is that in the column "Change" the version number is displayed correctly 0.0-1552, while in the pull request title it says "Update to v1552".

Did you see anything helpful in debug logs?
I'm seeing that major version is incorrectly resolved:

...
              {
                "fromVersion": "1.10.520",
                "toVersion": "0.0-1552",
                "newValue": "0.0-1552",
                "newMajor": 1552,
                "newMinor": 0,
                "updateType": "major",
                "isSingleVersion": true
              },

To Reproduce
Steps to reproduce the behavior:

1. Create repository with deps.edn:

{:deps {org.clojure/clojurescript {:mvn/version "1.10.520"}}

1. Configure Renovate to use deps-edn manager:

{
  "enabledManagers": [
    "deps-edn"
  ]
}

Expected behavior
I would expect for Renovate Bot not to open pull requests trying to update from version of a dependency like 1.10.520 to a version like 0.0-1552.

Additional context
I've tried comparing the version with semver and it throws an exception saying that 0.0-1552 is an invalid version number. Unfortunately early ClojureScript versions didn't follow semver rules.

I would appreciate if a special case can be added such that major version for 0.0-1552 would be 0.

[rarkins]

@zharinov what would be the best way for us to handle this?

[rarkins]

@mkarp this package rule should work around the problem for you:

  "packageRules": [{
    "packageNames": ["org.clojure:clojurescript"],
    "allowedVersions": ">= 1.7.10"
}]

@zharinov can you look into this as to whether we can fix it automatically at the root cause? I'm also confused why we call it "v3308" too.

[zharinov]

Hey folks, I'll take a look today on how to fix it

[renovate-bot]

:tada: This issue has been resolved in version 18.9.8 :tada:

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot :package::rocket:

[mkarp]

Thank you all!

[rarkins]

@mkarp the root cause fix should be live in the app within 5 minutes and after that no package rule should be necessary