Renovate: Broken changelog compare links

Created on 4 Feb 2019  路  4Comments  路  Source: renovatebot/renovate

What Renovate type are you using?
Renovate GitHub App

Describe the bug
Links to compare to scoped npm packages (at least our private ones) are broken.

To Reproduce
Not sure, in our case its private scoped packages from our lerna managed repo.

Expected behavior
Links to work 馃檭

Screenshots

### [`v1.0.7`](https://togithub.com/xxx/yyy/compare/@​xxx/[email protected]...@​xxx/[email protected])

Theres some suspicious ​ in the url, removing it and the link works fine. Doesn't show in chromes address bar tho so kind of confusing.

priority-3-normal bug

All 4 comments

​ is a kind of invisible character - a "zero width space" - that we insert sometimes to try to prevent GitHub unnecessarily "linking" to usernames whenever they see an @, because otherwise the user gets kind of spammed by notifications. Sometimes though we are too aggressive with adding this character.

Looks like we need to add a search to detect this type of broken compare link and restore it. Being able to reproduce it in a test repo would be a good first step. I think it would apply to any public or private source, but only when the tags are expressed like [email protected], which is quite an edge case.

@rarkins Made a recreation with public repo, with public packages

Set up a standard lerna repo here with scoped packages Flydiverny/renovate-3162
And then a repository which depends on one of the scoped packages here Flydiverny/renovate-3162-dep

Which renovate then generated this PR https://github.com/Flydiverny/renovate-3162-dep/pull/2
Which has the broken links as reported above :)

@Flydiverny thanks very much for reproducing it! I think the new patch should fix your problems

:tada: This issue has been resolved in version 14.29.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Was this page helpful?
0 / 5 - 0 ratings