Renovate: semanticCommitType not applied correctly

Created on 1 Jun 2019  路  13Comments  路  Source: renovatebot/renovate

What Renovate type are you using?
Renovate GitHub App

Describe the bug
Expect commit message from Renovate to contain emoji prefix as configured, which wasn't applied correctly

Did you see anything helpful in debug logs?
Job ID #70208446 : project config being correctly used from .renovaterc.

To Reproduce
Steps to reproduce the behavior:

  1. Create repository with .renovaterc :
{
  ...,
  "semanticCommitType": ":arrow_up:",
  "semanticCommitScope": null,
  "packageRules": [
    {
      "updateTypes": [
        "lockFileMaintenance",
        "pin"
      ],
      "semanticCommitType": ":pushpin:"
    },
    {
      "updateTypes": [
        "rollback"
      ],
      "semanticCommitType": ":arrow_down:"
    },
    {
      "updateTypes": [
        "digest",
        "bump"
      ],
      "semanticCommitType": ":bookmark:"
    }
  ]
}
  1. Wait next PR opened by RenovateBot to upgrade dependencies

Expected behavior
e.g. with PR Update dependency @commitlint/cli to v8
I would have expected the commit message to be :
猬嗭笍Update dependency @commitlint/cli to v8
Instead I got :
Update dependency @commitlint/cli to v8

Screenshots
Screen Shot 2562-06-01 at 14 15 13
or directly here

Additional context
I heavily rely on these semanticCommitType to be applied correctly, as I use a special preset for semantic-release based on gitmoji.

All 13 comments

Are you extending any of Renovate鈥檚 other presets?

No, I just use this .renovaterc only.

It follows our former discussion here :)

Can you replicate this in a public repo with similar config? That will make it a lot faster to debug

I also added you as a collaborator on the repo in case you want to process some additional tests 馃憤

I worked out the problem, but perhaps it now uncovers a new one. The 猬嗭笍 symbol is not being translated in the title in my test repo:
image

Is that expected?

Yes => :arrow_up:

The only thing that matters for semantic-release is :arrow_up: (or other emoji code), then usually Github display it with a nice symbol like 猬嗭笍 (which is just formatted on display)

Strange thing is that GitHub isn't formatting it nicely for me when I test.

Anyway, the solution is to add this config: "semanticCommits": true. I also released a patch 18.7.2 that makes sure you don't end up with two semicolons in a row.

That's awesome, thanks !

One last thing @rarkins : can I delete the test repository ?

Yes go ahead

Was this page helpful?
0 / 5 - 0 ratings