Renovate: Node Support Policy Wipes Travis Configuration

Created on 5 Jun 2018  路  2Comments  路  Source: renovatebot/renovate

What Renovate type are you using?

Renovate GitHub App

Describe the bug

Our conventional-changelog mono-repository is setup with the following node support policy:

"node": {
  "enabled": true,
  "supportPolicy": ["lts", "current"]
},

Our .travis.yml configuration file:

language: node_js

node_js:
  - 6
  - 8

matrix:
  fast_finish: true

cache:
  directories:
    - node_modules/
    - ${HOME}/.npm

before_install:
  - npm install --global npm@latest

before_script:
  - git config --global user.name 'CI'
  - git config --global user.email '[email protected]'

script:
  - npm test

after_script:
  - nyc report --reporter=text-lcov | coveralls

Is getting replaced with:

 language: node_js

 node_js:
  - '8'
  - '6'
  - '10'

Our custom scripts are required for our unit tests to execute.

Here's the relevant pull request - https://github.com/conventional-changelog/conventional-changelog/pull/333

To Reproduce

Steps to reproduce the behavior:

  1. Fork the conventional-changelog mono-repository

Expected behavior

I would expect _just_ the node_js section to be updated with a new list of Node versions, and for all other sections to be left as was.

priority-2-important bug

Most helpful comment

@hbetts sorry, that was a nasty one. I have fixed the regex that accidentally selected the entire rest of the file, also improved detection of non-quotation marks in the travis array and the branch naming, which were also undesirable. Once the fix goes live in the app, it should autoclose that bad PR and create a new fixed one.

All 2 comments

@hbetts sorry, that was a nasty one. I have fixed the regex that accidentally selected the entire rest of the file, also improved detection of non-quotation marks in the travis array and the branch naming, which were also undesirable. Once the fix goes live in the app, it should autoclose that bad PR and create a new fixed one.

:tada: This issue has been resolved in version 12.46.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Was this page helpful?
0 / 5 - 0 ratings