Refined-github: Setup auto-publishing for Safari version

[fregante]

Refined GitHub is now also compatible with Safari (https://github.com/sindresorhus/refined-github/pull/3677), but it's not available on the App Store nor it's signed.

We need your help to:

• [ ] Configure Fastlane: https://docs.fastlane.tools/getting-started/ios/appstore-deployment/
• [ ] Setup the FastLane deployment action: https://github.com/marketplace/actions/fastlane-action

How to build

1. Install XCode 12 and Safari 14
2. In Safari, enable Allow Unsigned Extensions in the Develop menu.

3. Run:

   npm install
   npm run build
   npm run pack:safari
   npm run start:safari
   

4. In Safari, click on the extension icon while on GitHub.com to enable it.

---

IssueHunt Summary

Backers (Total: $40.00)

• darthshadow ($10.00)
• fregante ($10.00)
• $20.00 have been anonymously funded.

Become a backer now!

Or submit a pull request to get the deposits!

Tips

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on IssueHunt to raise funds.
  

[issuehunt-app[bot]]

@darthshadow has funded $10.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[issuehunt-app[bot]]

@fregante has funded $10.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[fregante]

@lautis would you like to copy your fastlane setup to this repo?

I think that the Safari version might need some changes to manifest.json, so feel free to copy the distribution folder to distribution-safari in a build step if necessary.

[0-vortex]

can pick this up in the morning if that's ok

[fregante]

Yes please!

[0-vortex]

Hey guys just finished reading the docs for fastlane and the great work over at lautis/refined-github-safari/fastlane

So far I have 1 issue related to certificates - looking at docs.fastlane.tools/actions/match I believe sharing a provisioning profile would reduce the safari github action to:

npm run build
bundle exec fastlane sign

Due to limitations I understand the appstore lane should be on a manual trigger to avoid potential double submit ?

If match is not appealing (overhead) the other simple solution would be to set up a CI machine with a temporary application password. I value this approach because it enables rapid development on a beta/staging lane with hardcoded Appfile values as described in docs.fastlane.tools/advanced/Appfile

While the above methods are friendly enough for non-apple developers to contribute on the extension, my main motivation is keeping the workflow logic (setting up ruby, node, auth and running commands) separated from fastlane and app store flows.

If that sounds good I would be happy to move forward with a CI provisioning profile and automated github action builds for a pre-production environment - this can be used as an artifact to solve spam lagging app store releases or just compare with live version.

TL;DR: Apple release process can be hacked quickly but I am not experienced enough in solving the credentials issue :D

Happy to know your thoughts !

[gingerbeardman]

Will Safari version support macOS 10.14 Mojave? Hope so! Thanks.

[lautis]

Yes, if you have Safari 14.

[gingerbeardman]

Thank you!

[sindresorhus]

If match is not appealing (overhead) the other simple solution would be to set up a CI machine with a temporary application password. I value this approach because it enables rapid development on a beta/staging lane with hardcoded Appfile values as described in docs.fastlane.tools/advanced/Appfile

I prefer the CI machine approach. I would like the simplest setup possible.

[issuehunt-app[bot]]

An anonymous user has funded $20.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[gibfahn]

Got this working locally without having to tick the "Allow Unsigned Extensions" box every time you launch Safari. Basically @fregante 's instructions above, then the self-signing instructions from https://stackoverflow.com/questions/62748163/how-can-i-sign-a-safari-extension-for-just-one-computer.

git clone https://github.com/sindresorhus/refined-github && cd refined-github

# The GitHub enterprise "allow on this website" bit wasn't working in Safari, so I edited distribution/manifest.json
# To change github.com to github.mycompany.com with:
# gsed -i 's/github.com/github.mycompany.com/g' distribution/manifest.json

npm install
npm run build
npm run pack:safari
npm run start:safari

# Open app in Xcode
open "safari/Refined GitHub.xcodeproj"

In Xcode:

• Menu Bar -> Product -> Archive
• Click "Distribute App"
• Click "Development"
• Sign in with Apple ID and register for the (free) developer account if you haven't already
• Choose <Me> (Personal Team)
• Automatically manage signing
• Export
• Save to somewhere, e.g. ~/tmp
• Close Xcode

Outside of Xcode:

• Move the app inside the folder you just exported to /Applications, e.g. mv ~/tmp/Refined GitHub*/Refined GitHub.app /Applications
• Open the app: open /Applications/Refined GitHub.app
• Click the button on the app when it opens to open Safari extension preferences.
• Enable app in preferences.
• Open your github homepage, click the app in the Safari URL bar, click "Allow always for this website"

Then everything started working for me.

[markdorison]

To get Fastlane configured, we will need to provide Apple ID developer credentials. Is it safe to assume that the project maintainer (@sindresorhus), or a collaborator @sindresorhus trusts and specifically delegates to should handle this?

[fregante]

I just fixed some issues in the Safari version due to my dependencies, but I haven't updated them here yet.

• https://github.com/fregante/webext-options-sync-per-domain/releases/tag/v2.0.2
• https://github.com/fregante/webext-options-sync/releases/tag/v2.0.1

[L1cardo]

Any news on this issue?
I am using a self-built version, but I am looking forward to the official release.

[sindresorhus]

Apple rejected the extension because "GitHub" is a trademarked name. We are working with GitHub on getting it approved. It will probably be another month until it's in the store though.

[gingerbeardman]

@sindresorhus you can rephrase it as "Refined for GitHub" in the App Store listing. The app file can keep the Refined GitHub name.

I had this years ago with a stats viewer for Mario Kart 8, I originally called it "Mario Kart 8 Combo Explorer" but in the end I had to call it "Combo Explorer for Mario Kart 8" under the advice of Apple App Store staff. There are lots of examples of this sort of thing on the store, search "for".

eg.

• Streaks for GitHub
  https://apps.apple.com/gb/app/streaks-for-github/id1274680634?mt=12
• Duplicate Cleaner for iPhoto
  https://apps.apple.com/gb/app/duplicate-cleaner-for-iphoto/id586862299?mt=12
• Sourcegraph for Safari
  https://apps.apple.com/gb/app/sourcegraph-for-safari/id1543262193?mt=12
• Simplified for Twitter
  https://apps.apple.com/gb/app/simplified-for-twitter/id1479307973?mt=12
• FreeChat for WhatsApp
  https://apps.apple.com/gb/app/freechat-for-whatsapp/id1084346074?mt=12

Of course there are also a bunch of apps that use GitHub in the normal way without issue!

[fregante]

Right, but we are getting the approval, so it’s just a matter of waiting.

[gingerbeardman]

If that's the case it wasn't clear from Sindre's post, which was less definite.