Refined-github: Release links are lowercased

Created on 14 Oct 2020  路  3Comments  路  Source: sindresorhus/refined-github

https://github.com/BtbN/FFmpeg-Builds has Releases link https://github.com/btbn/ffmpeg-builds/releases instead of https://github.com/BtbN/FFmpeg-Builds/releases
All other tabs respect letter case, releases-tab feature should respect it too. Sidebar Releases block which is removed by this feature also respects letter case.

bug help wanted

Most helpful comment

What's the harm in having it lower cased? The link still works as expected for me and I likely wouldn't have even noticed.

All 3 comments

This is because we normalize the capitalization in the function getRepoURL. Maybe we should review its usage and see if it can reliably get the correct the capitalization elsewhere, at least when we use it to generate links (as opposed to comparisons and cache keys)

What's the harm in having it lower cased? The link still works as expected for me and I likely wouldn't have even noticed.

@busches generally I agree, this is not an actual issue, but the solution seems easy enough. Even if we forget to preserve the capitalization sometimes, we can still try.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

hkdobrev picture hkdobrev  路  3Comments

sindresorhus picture sindresorhus  路  3Comments

shivapoudel picture shivapoudel  路  3Comments

Celthi picture Celthi  路  3Comments

MilesBHuff picture MilesBHuff  路  3Comments