Refined-github: Fix PR commit links on submission (GitHub’s bug)

[fregante]

GitHub has had this really annoying bug that changes PR commit links (e.g. this one) into non-PR-related links like this: https://github.com/sindresorhus/refined-github/commit/cb44a4eb8cd5c66def3dc26dca0f386645fa29bb

This only happens to auto-linked URLS like https://...etc and not to [text](https://...etc)

We can't fix these links after they've been submitted but we can do it before submission.

---

This feature should should:

1. Listen to comment form submissions
2. Detect plain URLs to PR commits (and skip markdown links)
3. Replace plain urls with identical markdown links, like [https://...etc](https://...etc)

Step 2 is easy to implement in most places (e.g. find a URL surrounded by spaces) but it can be tripped with content like [this url https://... is the problem](https://...) (which... probably does not happen)

Test comment content:

https://github.com/sindresorhus/refined-github/pull/3/commits/cb44a4eb8cd5c66def3dc26dca0f386645fa29bb

---

IssueHunt Summary

max-arias has been rewarded.

Backers (Total: $18.81)

• fregante ($18.81)

Submitted pull Requests

- #3085 Added feature to stop GH from replacing Pr links to commit links

Tips

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on IssueHunt to raise funds.
  

[fregante]

cc @lukehefson just in case he can fix this internally.

[lukehefson]

Thanks for the ping @fregante! Did you submit a bug report to our Support team? And if so, do you think you could DM (twitter, email) me the ticket reference?

[issuehunt-app[bot]]

@fregante has funded $18.81 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[max-arias]

looks like this was solved?

[fregante]

https://github.com/sindresorhus/refined-github/pull/3/commits/cb44a4eb8cd5c66def3dc26dca0f386645fa29bb

[fregante]

Nope. I just posted 1 but the link points to 2

1. https://github.com/sindresorhus/refined-github/pull/3/commits/cb44a4eb8cd5c66def3dc26dca0f386645fa29bb
2. https://github.com/sindresorhus/refined-github/commit/cb44a4eb8cd5c66def3dc26dca0f386645fa29bb

This issue is considered solved (by GitHub) when the link I just posted points to a PR commit, not a plain commit.

[max-arias]

I'll give this a shot!

[max-arias]

Pr up: https://github.com/sindresorhus/refined-github/pull/3085

[issuehunt-app[bot]]

@sindresorhus has rewarded $16.92 to @max-arias. See it on IssueHunt

• :moneybag: Total deposit: $18.81
• :tada: Repository reward(0%): $0.00
• :wrench: Service fee(10%): $1.89

[wearhere]

This is really cool—the find of feature that makes me proud to use Refined GitHub. Nice work everyone. The styling of the warning is especially nice.

[fregante]

Glad you like it, this bug annoyed me for a long time.

Some fixes to this feature are coming in #3223