Refined-github: `sticky-discussion-sidebar` feature broken

Created on 8 Aug 2019  路  3Comments  路  Source: sindresorhus/refined-github

The .discussion-sidebar class doesn't exist anymore, will need to use #partial-discussion-sidebar to target the sidebar element instead.

image

bug help wanted

Most helpful comment

Hi.
~Actually, it looks like they made our job easier with this clean-up.~
I will address this issue now.

Ref of the previous fix: #2294

All 3 comments

This was changed last week, did they change class again? 馃

That class existed on the element with the id mentioned above, but we always used the class to target the sidebar since the feature was originally introduced. It doesn't exist anymore on the page.

I think they're dropping classes for all the elements that already have an id. If that's the case, we should expect some more broken features.

Hi.
~Actually, it looks like they made our job easier with this clean-up.~
I will address this issue now.

Ref of the previous fix: #2294

Was this page helpful?
0 / 5 - 0 ratings

Related issues

hkdobrev picture hkdobrev  路  3Comments

mareksuscak picture mareksuscak  路  3Comments

olso picture olso  路  3Comments

hkdobrev picture hkdobrev  路  3Comments

fregante picture fregante  路  3Comments