Refined-github: Should Subscribe reason be hidden in Sidebar?

Created on 24 Jul 2019  路  11Comments  路  Source: sindresorhus/refined-github

Issue

The feature clean-sidebar hides the subscribe reason in the code below:
https://github.com/sindresorhus/refined-github/blob/4bc3f3aa213de18d89c32df454957752400f249f/source/features/clean-sidebar.css#L6-L9

Screenshots

  • UX (without refined-github on left, and with refined-github on right)
    BeforeAfter

  • DevTools
    DevTools

Expected behavior

  • Power GitHub users who use refined-github extension are subscribed to multiple issues and might want to know the reason why they're subscribed to particular issue in order to decide if they want to Unsubscribe. The reason shown below Unsubcribe button is helpful.
  • clean-sidebar feature description states Hide all empty sections (or just their "empty" label) in the discussion sidebar. As per description, it shouldn't hide non-empty reason for subscription.
change request good first issue help wanted

Most helpful comment

What do you feel about showing reason in sidebar?

As of now, I'm overriding this behavior by writing following custom CSS in my extension:

.sidebar-notifications .reason {
    display: inline-block !important;
}

All 11 comments

What do you feel about showing reason in sidebar?

As of now, I'm overriding this behavior by writing following custom CSS in my extension:

.sidebar-notifications .reason {
    display: inline-block !important;
}

Any update on this request?

Can we at least move the following CSS to a new feature (say hide-subscription-reason) so that it doesn't break existing users? https://github.com/sindresorhus/refined-github/blob/4bc3f3aa213de18d89c32df454957752400f249f/source/features/clean-sidebar.css#L6-L9

The users who like to see the subscription reason will just be able to disable that feature, without affecting other clean-sidebar features

Any update on this request?

I'll post a PR over the weekend to move the below CSS to new feature hide-subscription-reason:
https://github.com/sindresorhus/refined-github/blob/4bc3f3aa213de18d89c32df454957752400f249f/source/features/clean-sidebar.css#L6-L9

This is not big enough to justify a whole feature for it. Either it goes or it stays and you keep the CSS in the Custom CSS field.

cc @sindresorhus

The copy looks a bit messy there with the Mark as unread button but perhaps it can be moved _above_ Subscribe via flexbox

This is how "Mark as unread" button will look like if moved above Subscribe
Screen Shot 2019-08-05 at 7 18 47 AM

I meant _the copy_ can be moved above the subscribe button:

subscribe reason
[unsubscribe button]
[mark as unread button]

Screenshot as per suggestion from @fregante
Screen Shot 2019-08-05 at 11 14 12 PM

Sure, we can bring back the subscribe reason.

Sure, we can bring back the subscribe reason.

Cool! Where should the subscribe reason be placed?

  1. Original location (below Subscribe/Unsubscribe button)
    61831574-0dcae580-ae23-11e9-96bd-0fe3dd060800

  2. Original location, with "Mark as Unread" button moved to top
    62471344-636f8e00-b751-11e9-998d-7e1415c77e93

  3. New location, above Subcribe/Unsubscribe button
    62515316-d838db80-b7d6-11e9-8e02-17b6188ba8ca

My vote goes for 2, as it's minimal changes from the default behavior from UX perspective

I think 3 is best. We shouldn't flip the two buttons like in 2, especially because Mark as unread is added later so it will replace Unsubscribe (causing possible mis-clicks)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

olso picture olso  路  3Comments

alexanderadam picture alexanderadam  路  3Comments

vanniktech picture vanniktech  路  3Comments

sompylasar picture sompylasar  路  3Comments

shivapoudel picture shivapoudel  路  3Comments