Refined-github: Add opt-in setting to remove diff signs

Created on 2 Aug 2018  路  5Comments  路  Source: sindresorhus/refined-github

There is (or was) a feature called remove-diff-signs.js, but it's intention is to make the diff signs unselectable. Personally I think those signs are redundant in combination with the background colors in the diffs and can be removed.

If this feature request is approved, then the following code is probably all you need to include:

.blob-code-marker-addition:before,
.blob-code-marker-context:before,
.blob-code-marker-deletion:before {
    display: none !important;
}
enhancement help wanted

All 5 comments

those signs are redundant in combination with the background colors

Fun fact: the feature was actually called "remove-diff-signs" because that's exactly what its first version did. (https://github.com/sindresorhus/refined-github/pull/254) However the original PR was later changed because relying on colors made it less accessible. https://github.com/sindresorhus/refined-github/pull/254#issuecomment-228229599

I'd be fine with that but others might not. Either way since it's just simple CSS you can just place that in the options rather than add it as a default.

I think this would be nice, but for accessibility reasons, it should be opt-in.

Reopening as I think we should make this an opt-in setting.

@bfred-it Are you still against this even if it's opt-in? I agree it's not a good default for accessibility reasons, but I personally find the plus/minus moot as the colors are enough for me, so I'd like to opt into hiding those, as they just create visual noise.

Opt-out can be done. Opt-in not so much :)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Arcanemagus picture Arcanemagus  路  3Comments

supremebeing7 picture supremebeing7  路  3Comments

MilesBHuff picture MilesBHuff  路  3Comments

mareksuscak picture mareksuscak  路  3Comments

hkdobrev picture hkdobrev  路  3Comments