Refined-github: Remove whitespace toggle

[levrik]

GitHub itself offers this functionality now.

[notlmn]

IMO thats a bad move from GitHub. I'm glad GH added that option but to perform some temporary action like "Toggling whitespace changes" takes 3 clicks instead of RGH's 1 click option.

Users are more likely to use the "Toggle whitespace" option in case of large PRs (where we can ignore whitespaces changes if linting tests pass), and less likely use "Unified/Split view" as it is persistent anyway.

But still, I'd like to know other people opinion too!

[levrik]

@notlmn Maybe hide the option by GitHub then if the extension is installed.

[sindresorhus]

I would prefer to hide the native GitHub toggle.

[fregante]

I would prefer to hide the native GitHub toggle.

In that case, the current add-diff-view-without-whitespace-option needs to be changed to something like "set diff settings faster" and also extract the Unified/Split form

[fregante]

What if we just replace the text with one of these icons?

[busches]

@bfred-it I like the icon idea, would we also want to hide the "Just for now" section, if the add-diff-view-without-whitespace-option is enabled?