Refined-github: Automatic "has PR" tag

[fregante]

Like #1078 shows what PR closed an issue, we can show what PR _will_ close an issue.

Like for #1078, we already have this information somewhere in the thread:

Perhaps we can use the same style GitHub uses to link to PRs in branch pages that have open PRs, example: https://github.com/sindresorhus/refined-github/tree/merge-commits

Mockup for this feature:

To keep in mind: there might be multiple PRs trying to close an issue so multiple buttons would be shown in that case.

[hkdobrev]

Best feature ever! :raised_hands:

[sangeeth96]

@bfred-it How should the layout of the buttons be if there are multiple PRs?

[fregante]

I think we can just pile them up 10px away from each other to avoid over-complicating it. There shouldn't be more than 2-3 in most cases.

[hkdobrev]

I'd suggest to change the View #XXX button in the tree view to also use the icon to indicate it's a PR.

[fregante]

I'd suggest to change the View #XXX button in the tree view to also use the icon to indicate it's a PR.

Separate feature? It matches different pages

[fregante]

Has PR! Check it out on this very issue.

[hkdobrev]

I've double checked that all of our open issues with the "has PR" tag has a closing PR link in the header. One didn't and I've updated the PR description. So I'm deleting the "has PR" label 🎉. We're losing the ability to filter by that filter, but it reduces the effort of adding that label back since only collaborators could edit labels.

[fregante]

No wait this doesn't appear in lists, it's nice to see what issues are already being fixed

[hkdobrev]

No wait this doesn't appear in lists, it's nice to see what issues are already being fixed

OK, I'll add it back, but I think it's a bigger burden than the benefits. For me the bigger benefit is to not start working on an issue where an implementation has started and is being discussed. And you see that from the issue page.