Refined-github: PR approved by whom avatars

[foodpoison]

Hi guys, good job on the plugin.
I have a small request, similarly to how we currently have the Reaction Avatars, it would be great to show avatars of people that have so far approved the PR.
Our team goes by a "two approval before you can merge" policy, and this will greatly speed up that process, at a glance we can immediately see which PRs are ready to merge, as opposed to having to click into the PR to count the number of clicks.

[fregante]

It's already there, provided by GH in the sidebar:

[hkdobrev]

at a glance we can immediately see which PRs are ready to merge, as opposed to having to click into the PR to count the number of clicks.

@bfred-it I think what @foodpoison means is that they want avatars in the PR list next to the green check. At the moment the GitHub filter review:approved considers a PR as approved as soon as one person approves, you cannot filter by a number of approvals.

[fregante]

Oh, got it, I had missed the last sentence. I guess he means this:

From

To

[fregante]

Showing the numbers seems pretty easy, it already appears in the attributes:

It's not names/avatars but it's something, PRs welcome!

[hkdobrev]

Showing the numbers seems pretty easy, it already appears in the attributes

@bfred-it Wow, nice catch! I could really use that!

I guess as a start we can just visualise that ARIA label somehow and think about something more later down the road.

The question is how to visualise it - just as a number or visualise it by multiple icons.

---

I've checked the ARIA label on different pull requests and I have some bad news.

Here are some of the different cases:

• "Review required before merging" (when no one has reviewed yet)
• "1 review requesting changes" (even when one person has requested changes multiple times which is completely fine)
• "1 review approval" - works as expected
• "2 review approvals" - works as expected
• "4 reviews requesting changes" - This is shown even after 3 of those reviewers have approved and only one hasn't. I.e. you see this in the PR sidebar:

[fregante]

@hkdobrev yeah the information isn't great when there are change requests, but if the change requests have been fulfilled or if _"they're fine"_ they can be dismissed by collaborators.