Refined-github: #751 introduced the inability to post multiline comment

Created on 3 Nov 2017  Â·  7Comments  Â·  Source: sindresorhus/refined-github

Because it assumes I am only intend on submitting a single line comment....
on windows Shift+Enter is reserved for making single new line.

However enter on Github is new line yes, but I cannot change my habit cause I always assume Enter is for submitting. That's why shift enter is my gotoguy for new line.

change request

Most helpful comment

Reminds me of:

workflow_2x

All 7 comments

Because it assumes I am only intend on submitting a single line comment....
on windows Shift+Enter is reserved for making single new line.

However enter on Github is new line yes, but I cannot change my habit cause I always assume Enter is for submitting. That's why shift enter is my gotoguy for new line.

shift+enter is used to make new lines on Mac too — when the standard enter is mapped to “new paragraph”. As far as I know this only happens in word processing software. Code editors don’t have the concept of “paragraph” so shift just doesn't change the result, usually.

Browsers' <textarea> also ignore the shift. Since enter is easier to press than shift+enter, people just use the former.

Reminds me of:

workflow_2x

I hate changes that break muscle memory, too. But shiftenter seemed like the least-bad option for the shortcut, since ctrlshiftenter triggers the full review as well.

Closing as it's working as intended.

Is it possible to disable shift + enter for single line comment, I would like to keep the default behaviour of new line? What do I enter in the "Disable Features" box to disable it? I have enabled logging, but my console is still empty. I might need to restart my browser - but way too many tabs opened to do that right now. :)

I have enabled logging, but my console is still empty.

You probably just have to reload GitHub's tab

What do I enter in the "Disable Features" box to disable it?


@bfred-it Thanks! :) Looks like it disables everything in that file. I'll edit that part of code and prepare my own extension - because I am happy with the remaining ones. Thanks!

You probably just have to reload GitHub's tab

Yep :)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

yakov116 picture yakov116  Â·  3Comments

hkdobrev picture hkdobrev  Â·  3Comments

mareksuscak picture mareksuscak  Â·  3Comments

Arcanemagus picture Arcanemagus  Â·  3Comments

Celthi picture Celthi  Â·  3Comments