Refined-github: Error on news feed "Uncaught (in promise) TypeError: Cannot read property 'disconnect' of undefined"

[yakov116]

auto-load-more-news.js:41 Uncaught (in promise) TypeError: Cannot read property 'disconnect' of undefined
    at findButton (auto-load-more-news.js:41)
    at observeEl (utils.js:47)
    at auto_load_more_news (auto-load-more-news.js:51)
    at safely (utils.js:10)
    at content.js:610
    at <anonymous>
findButton @ auto-load-more-news.js:41
observeEl @ utils.js:47
auto_load_more_news @ auto-load-more-news.js:51
safely @ utils.js:10
(anonymous) @ content.js:610
async function (async)
(anonymous) @ content.js:583
(anonymous) @ content.js:712
__webpack_require__ @ bootstrap a6ef299f59b18502cc11:19
(anonymous) @ bootstrap a6ef299f59b18502cc11:62
(anonymous) @ bootstrap a6ef299f59b18502cc11:62

[yakov116]

@bfred-it Not this it makes this a more important issue. But my custom changes to the feed no longer work. 😞

[yakov116]

@bfred-it I don't know what you changed but I just updated my repo and the issue is no longer there!

Thanks

[yakov116]

Um I take that back 😞 The error is there but my feeds are working again

[fregante]

Neat! The bug had always been there but it only surfaces when you reach the end of the newsfeed. Minor issue anyway, it just kept listening for changes unnecessarily.

[yakov116]

content.js:1615 Uncaught (in promise) TypeError: Cannot read property 'getAttribute' of null
    at getUsername (content.js:1615)
    at addYoursMenuItem (content.js:1265)
    at safely (content.js:1615)
    at select_dom_default.a.exists.github_injection_default (content.js:1878)
    at module.exports.cb (content.js:839)
    at Object.<anonymous> (content.js:1877)
    at __webpack_require__ (content.js:9)
    at content.js:28
    at content.js:29

@bfred-it Is this part of that same issue? I get this when opening my issues on the nav bar

[fregante]

⬇️

[yakov116]

@bfred-it found another one

more-dropdown.js:16 Uncaught (in promise) TypeError: Cannot read property 'after' of undefined
    at more_dropdown (more-dropdown.js:16)
    at safely (utils.js:10)
    at github_injection_default (content.js:557)
    at gitHubInjection (index.js:13)
    at onDomReady (content.js:555)
    at <anonymous>
more_dropdown @ more-dropdown.js:16
safely @ utils.js:10
github_injection_default @ content.js:557
gitHubInjection @ index.js:13
onDomReady @ content.js:555
async function (async)
onDomReady @ content.js:514
init @ content.js:511
__webpack_require__.URL.URL @ content.js:638
__webpack_require__ @ bootstrap fc446b7fa65d86637335:19
(anonymous) @ bootstrap fc446b7fa65d86637335:62
(anonymous) @ bootstrap fc446b7fa65d86637335:62
09:55:17.833 add-releases-tab.js:42 Uncaught (in promise) TypeError: Cannot read property 'before' of null
    at add_releases_tab (add-releases-tab.js:42)
    at safely (utils.js:10)
    at github_injection_default (content.js:558)
    at gitHubInjection (index.js:13)
    at onDomReady (content.js:555)
    at <anonymous>

When going into settings

[fregante]

That’s separate, do you mind opening an issue? It requires updating the page detection for both isRepo and isRepoSettings

Edit: opened as #783