Refined-github: Latest releases breaks spaces in PRs

Created on 7 Jul 2017  路  5Comments  路  Source: sindresorhus/refined-github

All 5 comments

I'm seeing this too. I think it's only for diffs that are loaded later.

Located issue: it's removeDiffSigns

Uhh the whitespace is collapsing once it's no longer prefixed by a - or +. The cause seems to be pre-wrap but I'm not sure if we should disable that. This looks like a headache.

pre-wrap

Hi, I installed today refined-github the first time. I also experienced a related bug with whitespacing. This bug here is not the same, but may get fixed in the same time.

My commit adds a single line without any preceeding whitespace, but it get's displayed with a small extra indentation (which is confusing).

Correct: (plain github)
screenshot from 2017-07-09 18-45-49

Wrong: (refined github enabled)
screenshot from 2017-07-09 18-45-15

The Raw commit is here: dunst-project/dunst@717c747a8caf0f823da0e4e45bbb632ef46c68ee

Weird. I don't see the issue in the OP at all (perhaps because I'm using Firefox).
I can recreate https://github.com/sindresorhus/refined-github/issues/590#issuecomment-313931801 however; moving it to a separate issue.

Was this page helpful?
0 / 5 - 0 ratings