Refined-github: Add a keyboard shortcut for "Add line comment"

Created on 9 Oct 2016  路  8Comments  路  Source: sindresorhus/refined-github

Since introducing reviews the CMD/Ctrl+Enter shortcut now adds a Review comment, rather than a single line. This would be fine, but we've been used to this shortcut adding a single line comment for years.

enhancement good first issue help wanted

All 8 comments

I see your point, but I'm using the new reviews extensively and the new default is more convenient for me. I use Cmd + Enter almost always to start a review and then on subsequent comments I continue using Cmd + Enter to add more comments to that review (the default green submit button then changes to "Add a comment to review").

When I do need to add a single comment I either use the mouse or tab navigation to select the "Add a single comment" button. It's a bit frustrating indeed given the old habit we all have, but the new default is quite productive for me with the new reviews.

馃憥 I think reviews as default is good. Very often you start with one comment and then you suddenly find more things to comment on and realize you should have done a review. Better to just do reviews all the time.

Okay, well how about adding a new shortcut to create single-line comments?

Sure, that would be useful.

@jbrooksuk Could you suggest a concrete keyboard shortcut? Thanks!

Maybe CMD+Shift+Enter?

@jbrooksuk Do you think you could work on a PR about this?

I have a PR open to add a keyboard shortcut for a single comment, but due to the way the event handling is done in public GitHub (it's different in Enterprise GitHub), I don't think a shortcut containing both ctrl and enter is going to work. The PR currently uses shiftenter, which is a little wonky, but is at least somewhat related to ctrlenter. But I'm open to suggestions.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

hkdobrev picture hkdobrev  路  3Comments

yakov116 picture yakov116  路  3Comments

sompylasar picture sompylasar  路  3Comments

alexanderadam picture alexanderadam  路  3Comments

vanniktech picture vanniktech  路  3Comments