React-vis: Build is broken

[mcnuttandrew]

It appears that an upstream dependency has broken with node 6 and 7 support (fsevents maybe?) and is causing the build to fail. This should be fixed asap!

[jckr]

Thanks Andrew. Will look into it as soon as I’m in front of a laptop.

On Sun, May 27, 2018 at 15:47 Andrew McNutt [e-mail]
wrote:

It appears that an upstream dependency has broken with node 6 and 7
support (fsevents maybe?) and is causing the build to fail. This should be
fixed asap!

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/uber/react-vis/issues/816, or mute the thread
https://github.com/notifications/unsubscribe-auth/AJRujnTo_mIPRHJfWBibhLthcIkMgrmyks5t2yzjgaJpZM4UPdmI
.

[lzhuor]

Hi @mcnuttandrew and @jckr, thank you for maintaining the repo.

I got a chance to take a look at the build error. It's caused by hoek package. I suppose 5.0.3 is not supported by node versions below v8.9. So downgraded hoek to 4.2.1. The build is a pass now.

ref #817

[jckr]

Oh so that's what happened. hoek was reported as having a vulnerability which is why i had bumped it up. Turns out the vulnerability had been fixed even in earlier versions of the module so that wasn't necessary. All in all, we don't need to have hoek 5.0.3. Thanks @lzhuor

[lzhuor]

@jckr My pleasure :P

[lzhuor]

Hi @jckr Apologies, I guess the previous PR is not rebased properly so the master doesn't have the change. Recreating a PR for it.

819