React-native-swipe-list-view: hiddenRow height wrong

[OstrichRunning]

hi:
SwipeRow.js
render() {
return (
styles.hidden,
{
//height: this.state.hiddenHeight,
//width: this.state.hiddenWidth,
}
]}>
{this.props.children[0]}

{this.renderRowContent()}

);
}

7 8 lines, i think is wrong, when i delete row ,the height is change but the value is not true,
in my code , i just set the hidden row style = 1 and fix this code ,
it can make the height right, i hope you can check it

[jemise111]

@OstrichRunning not sure what your issue is here. If you wouldn't mind pasting a more complete example I'd be happy to take a look.

Also people with height issues after deleting a row often have success by setting the recalculateHiddenLayout prop to false.

Maybe give that a shot as well

(sorry for the delay in responding!)

[OstrichRunning]

render() {
        return (
            <View style={this.props.style ? this.props.style : styles.container}>
                <View style={[
                    styles.hidden,
                    {
                        //height: this.state.hiddenHeight,
                        //width: this.state.hiddenWidth,
                    }
                ]}>
                    {this.props.children[0]}
                </View>
                {this.renderRowContent()}
            </View>
        );
    }

In my code, my rows height is differ, sometimes my hidden row height show error, can not equal row height, so when i comments this tow line out and set the hidden row flex = 1. the hidden row height is ok. so i think this tow line is wrong
(sorry for the delay in responding too!)

[jemise111]

Hey @OstrichRunning, so I'm not sure what problem you're facing specifically, but basically the way the component usually works is the hidden row's height and width are initially set to 0, and then it uses the height and width of the visible row component to set the height and width of the hidden row (see here: https://github.com/jemise111/react-native-swipe-list-view/blob/master/components/SwipeRow.js#L73).

So I can't get rid of those lines otherwise the hidden row wouldn't have the correct height/width in most cases.

My guess is maybe you are hard coding the heights of your hidden rows, and that is being overridden by the component.

Could you paste more code? I'd love to see how you are calling renderRow, renderHiddenRow, and the StyleSheet for those components. Thanks!

[OstrichRunning]

hey @jemise111, I have a bug, when i render different height rows, render row without set height(auto with text image component height), i do not know row height so i can not set hidden row. when the row component render i use onLayout callback method get row height, then set hidden row height, sometimes the hidden row height no equal row height.
i change your code, and set hidden row style flex = 1, in my app, i find this hidden row show right.
show like :

[jemise111]

Hey @OstrichRunning sorry for the delay. When you say

and set hidden row style flex = 1, in my app

Are you referring to the styles set here?

https://github.com/jemise111/react-native-swipe-list-view/blob/fc25078c703864f4f8b08f786f2012d8cfe1d42f/components/SwipeRow.js#L317

If so I can add a prop to you to set styles of the hidden row and maybe it's a win win for everyone :)

[OstrichRunning]

I think setting only flex without setting width&height, hidden row will show right.
if set height&width and set flex, set flex not work.
in my code, i set flex is not work, because in your code, you set height&width.
i hope you can make a test, set flex without height&width. if this ok, we will not care hidden row

[jemise111]

Okay @OstrichRunning I just pushed a branch called dont-set-hidden-height-width. Could you give this a try by setting your package.json to point to it in your project. Like this:

dependencies: {
    "react-native-swipe-list-view": "git://github.com/jemise111/react-native-swipe-list-view.git#dont-set-hidden-height-width"
}

Then you should be able to set the flex yourself and hopefully that fixes your issue. If that works I'll get it merged in and push it out in a new release. Let me know, thanks!

[jemise111]

Hey @OstrichRunning thanks for giving it a shot!

I'm gonna think about it and maybe implement a change in the future but seeing as you're not affected by this issue anymore and I don't have anyone else experiencing this I'm going to leave it alone for now and close this issue.

Good luck in your new job :)

[rickyliu93]

I have this issue too, the hidden height won't rerender when an item is removed on the list