Radarr: iCal content has an invalid format

Created on 26 Feb 2018  路  1Comment  路  Source: Radarr/Radarr

The contents of the iCal response appears to not be valid in some scenarios, which breaks integration with Google Calendar (gCal hangs while fetching the content).
I've also validated the contents against iCalendar validator and believe I have identified the cause of the use issue in the code.

For movies that are "Announced", no dates are emitted to the output, so a partial calendar entry is generated with the following content:

BEGIN:VEVENT
DTSTAMP:20180225T024035Z
SEQUENCE:0
STATUS:TENTATIVE
UID:NzbDrone_movie_7
END:VEVENT

That entry causes the following problem in the validator:

Missing DTSTART property in VEVENT near line # 6

In CalendarFeedModule, within the iteration of movies, the switch statement case for "Announced" movies just has a continue; statement, which causes the Event to be included without any dates.
In fact, at least in my case, the movie actually DID have InCinemas dates, but they are ignored for this status.

If "Announced" movies are to be excluded from the results, then the check should come prior to:
var occurrence = calendar.Create<Event>();

bug low

Most helpful comment

Should we add two events, in cinemas and physical (if we have both) for the ical feed?

>All comments

Should we add two events, in cinemas and physical (if we have both) for the ical feed?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

willmonahan picture willmonahan  路  4Comments

davidbonnici1984 picture davidbonnici1984  路  4Comments

codaamok picture codaamok  路  3Comments

Rouzax picture Rouzax  路  3Comments

scope999 picture scope999  路  3Comments