Powerlevel9k: Nerd-font mode is lack of some icons

[zqzten]

I use nerd-font mode in Powerlevel9k. Recently I enabled the dir_writable segment and found that the lock icon is missing.
After inspecting the icons.zsh I found that the lock icon is not included in nerd-font mode, however nerd-font does have a lock icon which is \uF023. So I wonder that is there any reason that some icons are not included in nerd-font mode?

[bhilburn]

Not being a nerd-font user myself, I can't comment on specific code points. That said, I think we have seen that code-point variation in nerdfonts can be problematic.

@kaymmm @lcorsini @akrueger - do you have the lock icon in the fonts that you are using? Should we move the code-point to \uF023?

[rjorgenson]

Maybe we should setup a wiki page where users can add which nerdfont fonts match the codepoints we have setup and which fonts have which missing code points. This could help us narrow down a list of supported nerdfonts with their sources and a resource for users who want to use other fonts to get correct code points.

[kaymmm]

It looks like the problem is that the LOCK_ICON, EXECUTION_TIME_ICON, and SSH_ICON aren't defined for nerdfont-fontconfig. The \uF023 codepoint looks good to me.

[lcorsini]

\UF023 looks good,
As for icons undefined, when I tried to make my patch I copied all icons defined in awesome-fontconfig in icons.zsh and those wheren't defined in the version I forked

[lcorsini]

I noticed also that there is some icons missing using the latest next branch on my linux pc at work
This is p9k next branch

This is my patch

apart from the amazon icons I miss node, todo and BSD icons. are there any changes that I'm not aware?
I've used latest SauceCodePro as my font

this is a diff of the two icons.zsh
EDIT wrong file
diff.txt

[bhilburn]

@lcorsini - Can you file a PR to replace the missing icons for the nerdfont option?

[lcorsini]

@bhilburn Ok done

[bhilburn]

Fixed by merge of #451!