Polaris-react: Prevent admin from re-rendering on form update

[kyledurand]

We need to prevent action measuring when screen is vertically resized

Screencast

[AsgardLeonardo]

Hi guys,
Found this GH via this Slack convo in # design-language.
I have a store reporting the same type of "glitch" but in the collections page:

They have some collections with rather long names which seem to be "out of bounds" and on top of the menus, causing the collection title to flicker and not be able to interact with the menus themselves and actually causing the whole store admin to eventually crash (in Chrome) needing to close the tab and every other Shopify tab.

If the New Design Language is disabled from our view, the (old) collection page shows just fine.

So far I have not been able to replicate this on my test store, not even with a super long name (and under the New Design Language)

Leaving another screencast :)

Merchant store collection example
Internal
ZD Ticket

[kyledurand]

Thanks @AsgardLeonardo I'll make this a priority today. cc @dfmcphee looks like we still have an infinite render issue

[kyledurand]

Some additional context: https://github.com/Shopify/polaris-react/pull/3576#issuecomment-719727459

[kyledurand]

And a bit more context. I found that the re-rendering of page actions on some pages is actually legit.

On the product details page, here, the preview action takes a new action on every change made to the product form. This is a sort of cached preview of anything that's been changed since save.

We'll have to be more explicit about when our actions do the measuring

[oldcheddar]

hey team 👋

I'm just adding two instances for tracking as I see this has already been prioritized 🙌

ZenDesk | Internal

• looks like this most of the merchant's products have longer titles so this is happening on the majority of their products.

ZenDesk | Internal

• example from this merch, it also looks like the Duplicate button disappears and reappears as the title moves.

[Rony-C]

Hi all,

I see this is closed but the issue is still persisting on the merchants store.

• Video here

I'm wondering if this is the same issue? It looks the same as the original video linked posted by Kyle

[kyledurand]

Thanks Rony, it was automatically closed when that PR shipped but we're still waiting on the release to hit web. https://github.com/Shopify/web/pull/34757. I'll close this when that's been pushed to production

[kyledurand]

This fix is in production now, feel free to re-open if the bug persists

[PaddyMoloney]

Hey folks, looks like this is still happening on certain stores https://app.shopify.com/services/internal/shops/10195793

[kyledurand]

Thanks Paddy, we had to revert the fix unfortunately. We have another PR up but it won't be shipped til after BFCM

[TaylorCyr]

Hi Kyle. Before the fix was reverted, I also had a merchant mention that the fix left his product title rendering like this:

At the time I was able to replicate, on Chrome. This product:

https://oceanside-photo-telescope.myshopify.com/admin/products/11230504202

[mediumjones]

Hey @kyledurand not sure if this had anything to do with it, but we updated the page title recently to add product status badges to it. I can try to dig up the PR if you think it'll help.

https://github.com/Shopify/web/issues/30082