Polaris-react: Button, plain, monochrome, disclosure & loading is borkened

Created on 24 Sep 2019  路  6Comments  路  Source: Shopify/polaris-react

Issue summary

The following code produces a filled loading SVG:

<div style={{color: '#bf0711'}}>
  <Button plain monochrome loading disclosure>
    Try again
  </Button>
</div>

Expected behavior

Not having a square.

Actual behavior

Screen Shot 2019-09-24 at 3 19 04 PM

Steps to reproduce the problem

Use the code state above.

Reduced test case

https://codesandbox.io/s/97nmz?module=App.js

Most helpful comment

changed the title ~Button, plain, monochrome, disclosure & loading is borken~ Button, plain, monochrome, disclosure & loading is broken

but borken was so much nicer 馃槶

All 6 comments

馃憢 Thanks for opening your first issue. A contributor should give feedback soon. If you haven鈥檛 already, please check out the contributing guidelines.

Looks like once loading to this combination of props, it visually breaks:

button

changed the title ~Button, plain, monochrome, disclosure & loading is borken~ Button, plain, monochrome, disclosure & loading is broken

but borken was so much nicer 馃槶

I prefer borken as well 馃槃

This issue has been inactive for 180 days and labeled with Icebox. It will be closed in 7 days if there is no further activity.

Still an issue

Was this page helpful?
0 / 5 - 0 ratings