Polaris-react: DropZone height is not respected

[asalisbury]

Issue summary

The <DropZone /> determines its size (height and width) based on width only. This makes certain valid use cases, where the default DropZone height isn't appropriate, impossible. For instance, this one:

DropZone is configurable to work at various sizes, however. For example:

Default

50 height, 50 width

So far, so good. Until...

50 height, unspecified width

Expected behavior

I would expect something more like:

50 height, unspecified width

Actual behavior

50 height, unspecified width

Notice that the DropZone is cut off at the bottom. That is because it actually returns to its default size (shown above).

Steps to reproduce the problem

1. Go to https://polaris.shopify.com/components/actions/drop-zone
2. Paste this code: <div style={{height: 50}}><DropZone /></div>

Specifications

• Are you using the React components? (Y):
• Polaris version number: latest
• Browser: All
• Device: All
• Operating System: All

[probot-shopify[bot]]

👋 Thanks for opening your first issue. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. You can also join #polaris on the Shopify Partners Slack.

[marisveide]

This bug is not fixed - still the DropZone doesn't respect the given height of the wrapper div.
Is this working for anybody?

[asalisbury]

Looks like #1138 is under review. This should probably be reopened until that PR merges. Does that sound right, @elizabethletourneau?

[elizabethletourneau]

Yes, I’ll open this now. @asalisbury

[marisveide]

Thanks so much!

[attila-berki]

Is there an update on this issue? We ran into a similar problem, the height of the DropZone is not calculated correctly.

https://github.com/Shopify/web/issues/22382

[probot-shopify[bot]]

This issue has been inactive for 180 days and labeled with Icebox. It will be closed in 7 days if there is no further activity.