Polaris-react: Percy false positives and test flakiness

[tmlayton]

Experiencing Percy false positives and test flakiness? Post a comment with the test that incorrectly failed.

Guidelines

1. Read though the existing flaky test comments before posting
2. Don’t post the same flaky test failure as someone else, instead upvote 👍 the other persons comment
3. One test per comment with:
   
   
   
   • screenshot of the actual and expected
   
   
   • a link to the build
   
   

[tmlayton]

/drop-zone/7

https://percy.io/Shopify/polaris-react/builds/930221

Looks like it took a screenshot before the component finished rendering. When visiting /drop-zone/7, the drop zone component flashes "unstyled" for a moment.

[chloerice]

/drop-zone/6

PR changes did not relate in any way to the the drop zone component.

[solonaarmstrong-zz]

/resource-list/3

In a PR for resource list, but I'm not sure why they're doubled up.

/resource-list/2

/resource-list/1

[chloerice]

Unchanged Badge stuff (no badge stuff in PR)

[jfangrad]

From this PR which didn't make any visual changes
/drop-zone/0

[solonaarmstrong-zz]

Drop zone may be giving false positives because of this: https://github.com/Shopify/polaris-react/pull/1434

[tmlayton]

This one is fun because it will be a different width almost every time 😄

/loading

https://percy.io/Shopify/polaris-react/builds/1108793

[solonaarmstrong-zz]

☝️ I wish we could provide a progress: number.

[tmlayton]

@amrocha can you make an issue in the public repo and update the bit.ly link in Percy? Removing the link from the Percy title is also an option, whatever you think works best.

[BPScott]

Gonna transfer this

[yourpalsonja]

@amrocha does https://github.com/Shopify/polaris-react/pull/1290 fix this? I don't have enough info to know for sure.

[amrocha]

It kinda does, this was more of an ongoing issue for tracking problems.

I haven't noticed any issues recently though, we might be good to close it!

[yourpalsonja]

I'm gonna close and if more issues come up, we can open a separate ticket for them, since this might not be super visible anymore.