Platformio-atom-ide-terminal: Fullscreen toggle seems broken with Atom 1.17.0

[satishmohan]

After upgrading to Atom 1.17.0, the fullscreen toggle button seems to be behaving weirdly. It shows the screen split into two panes.

Thanks
Satish

[satishmohan]

Is there an issue with $('.item-views').height() ?
```
  maximize: ->
    @subscriptions.remove @maximizeBtn.tooltip
    @maximizeBtn.tooltip.dispose()
 
    @maxHeight = @prevHeight + $('.item-views').height()
    btn = @maximizeBtn.children('span')
    @onTransitionEnd => @focus()
 
    if @maximized
      @maximizeBtn.tooltip = atom.tooltips.add @maximizeBtn,
        title: 'Fullscreen'
      @subscriptions.add @maximizeBtn.tooltip

      @adjustHeight @prevHeight
      btn.removeClass('icon-screen-normal').addClass('icon-screen-full')
      @maximized = false
    else
      @maximizeBtn.tooltip = atom.tooltips.add @maximizeBtn,
        title: 'Normal'
      @subscriptions.add @maximizeBtn.tooltip
      @adjustHeight @maxHeight
      btn.removeClass('icon-screen-full').addClass('icon-screen-normal')
      @maximized = true
 ```

[ivankravets]

What is your OS? I can't reproduce this issue.

[satishmohan]

I'm on macOs Sierra 10.12.4

[satishmohan]

Here's an example of what I'm talking about - after I hit the fullscreen toggle button - the screen gets mirrored into two parts - overwriting the vertical tab bars on Atom:

[satishmohan]

I was able to narrow it down a bit further - the split screen happens only when the output of a command fills up the screen - for example try running top within the terminal window. If I quit the top process, the window output becomes normal again. Seems like sizing issue...?

[satishmohan]

Is anybody else running into this issue? This was working perfectly with Atom 1.16...

[ivankravets]

I've received this issue today. It looks that when you change a height of window, that this issue comes. Try to close all windows, open new terminal and press maximaze. Does it work now?

[satishmohan]

No, I get the same issue. Try running "top" command when the terminal is maximized - it messes up the output.

Would it be possible to get a fix? I had this maximize button mapped to a keyboard shortcut and it was super handy :-)

[Fred-Barclay]

@satishmohan As a temporary workaround, you should be able to drag the terminal icon from the bottom panel up to your tabs and use it as a fullscreen tab.

Hope this helps!

[ivankravets]

Could you try v2.5.1 (just released)?

[satishmohan]

Hi I tried v2.5.1 - thanks for the update - but still see the issue.

How to reproduce: open a terminal (Cmd+Shift+T), run "top" inside the terminal shell - this will cause the terminal output to overwrite the whole atom screen.

Regards!

[seajean]

@ivankravets seems open terminal from the selected directory has broken too.

[gkid]

I am experiencing the same thing.
It looks as if when the terminal is in full screen - the size of the terminal is larger than the window (is extends past the bottom of the Atom window.
If instead of running 'top' while in full screen, you manually type lines until you reach the bottom of the window, you can see that the last line of text is actually underneath Atom's status bar. Once you enter yet another new line - the terminal window becomes mangled.
I can try to post some screenshots if it can help.

[satishmohan]

Yes that's correct - I see the same behavior.... Would this be too hard to
fix? I'm guessing its some size calculation somewhere which has broken now
in the newer Atom releases?

On Wed, Jul 5, 2017 at 9:19 AM Eran Gilon [e-mail] wrote:

I am experiencing the same thing.
It looks as if when the terminal is in full screen - the size of the
terminal is larger than the window (is extends past the bottom of the Atom
window.
If instead of running 'top' while in full screen, you manually type lines
until you reach the bottom of the window, you can see that the last line of
text is actually underneath Atom's status bar. Once you enter yet another
new line - the terminal window becomes mangled.
I can try to post some screenshots if it can help.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/platformio/platformio-atom-ide-terminal/issues/227#issuecomment-313152927,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACNxL_SRvCXjuVcrh-_1A6TwDtZv4pKLks5sK7eUgaJpZM4Nc5sQ
.

[finferflu]

This is still true with Atom 1.19. And it happens even when there's simply a long history of command, i.e. it's not related to any running command. It does not happen with new, just-created terminals.

[takumiabe]

In my case,
$('.item-views') returns 4 elements, and $('.item-views').height() returns first element's height.

I try $('.item-views').has('atom-text-editor').height() in atom dev-mode, but it fixed only partially:
if <atom-text-editor /> doesnt exists, it causes error.

<atom-text-editor /> exists only if the file is opened. so if user closed the file, height() return any valid value.

I think .item-views is not fit to calculate maxheight of atom's main area.
I'm new man of atom plugin development, so I cannot progress anymore... needs help.

[Devligue]

I am experiencing the same issue in atom 1.19.5

[ivankravets]

Fixed in https://github.com/platformio/platformio-atom-ide-terminal/pull/369