Packit-service: Reference test repository in the test job metadata

Created on 10 Feb 2021  路  7Comments  路  Source: packit/packit-service

Hello!

Would it be possible to use the test job metadata to reference a repository which contains the whole FMF tree with tests to run? Something along these lines:

    jobs:
    - job: tests
      trigger: pull_request
      metadata:
        targets:
        - fedora-all
        repo_url: "https://github.com/johnsmith/my-fabulous-tests"

I know that currently you can reference a test repository using FMF, but even for this you need to have an initialized FMF tree in the repo plus the respective FMF file. Being able to reference the test repo directly in packit.yml would be way nicer, imo.

I'm not sure if this RFE should be filed for Packit or TMT/TFT, so apologies if I chose the wrong project :-)

good-first-issue testing-farm user-experience

Most helpful comment

I suspect this needs https://github.com/packit/packit-service/pull/1021 as well, so we can use it with PaaS?

All 7 comments

Hey @mrc0mmand :wave:

This is definately the _right_ project to file this issue and this is a good proposal. Let's see what the others say, but I'm all for implementing this... and shouldn't be that difficult either.

I'd call it fmf_url and optional fmf_ref, but yes, makes sense.

    jobs:
    - job: tests
      trigger: pull_request
      metadata:
        targets:
          - fedora-all
        fmf_url: https://github.com/johnsmith/my-fabulous-tests
        fmf_ref: main  # optional, defaults to repo's default branch

It should be as easy as putting this into TF request payload instead of the source repo url/ref.

Looking at a possible implementation (so I could start playing with TFT in systemd) - wouldn't be necessary to extend the metadata-related classes in Packit as well? Like JobMetadataSchema and JobMetadataConfig.

Closed by packit/packit#1155, in case you feel the point of this issue was not fulfilled, please reopen

I suspect this needs https://github.com/packit/packit-service/pull/1021 as well, so we can use it with PaaS?

@mrc0mmand The change from #1021 has been deployed to the staging instance of the service.
Can you give it a try?
See #649 for instructions.

@mrc0mmand The change from #1021 has been deployed to the staging instance of the service.
Can you give it a try?
See #649 for instructions.

Thank you! I'll try to test it out as soon as I have some spare time on my hands (I already have the staging app enabled for my test repo, so it shouldn't be an issue).

Was this page helpful?
0 / 5 - 0 ratings