Packit-service: TypeError: run_testing_farm_handler() missing 2 required positional arguments: 'chroot' and 'build_id'

[sentry-io[bot]]

Sentry Issue: RED-HAT-0P-32S

TypeError: run_testing_farm_handler() missing 2 required positional arguments: 'chroot' and 'build_id'
(2 additional frame(s) were not displayed)
...
  File "packit_service/worker/jobs.py", line 330, in process_jobs
    group(signatures).apply_async()
  File "celery/canvas.py", line 1007, in apply_async
    results = list(self._apply_tasks(tasks, producer, app, p,
  File "celery/canvas.py", line 1089, in _apply_tasks
    sig.apply_async(producer=producer, add_to_parent=False,
  File "celery/canvas.py", line 229, in apply_async
    return _apply(args, kwargs, **options)
  File "celery/app/task.py", line 532, in apply_async
    check_arguments(*(args or ()), **(kwargs or {}))

[csomh]

Removed the "testing" label as it doesn't impact the testing of this project but the /packit test command.

[lbarcziova]

This happens only for /packit test comment, because before the TheJobTriggerType refactor we had a specific handler for the test comment and the TestingFarmHandler for handling copr build end trigger. For handling copr build end we need:

• build_id to get the specific DB trigger from build model
• chroot so that we know for which chroot we should run the tests

But since these 2 handlers are unified, we need to make the 2 arguments optional since:

• if the original event was a comment (chroot is None), we run the tests for all chroots defined (in the previous comment handler)
• if the original event was a comment (build_id is None), we can directly create PullRequestModel as a trigger

[lachmanfrantisek]

@lbarcziova Yes, you are right. Can you please send a fix?

I've been a bit confused why it's coming from stage, but realized that we already have those changes on prode.

[lbarcziova]

@lachmanfrantisek yes, I will send a fix.

[lachmanfrantisek]

Thanks!