Packit-service: Make check runs conclusion "neutral" when user is not part of organization

Created on 29 Jul 2020  路  10Comments  路  Source: packit/packit-service

Current state

Check runs for all chroots are marked as "failed" when the user is not part of organization.

Proposed state

Check runs for all chroots are marked as "neutral" therefore it will not mark the whole PR as "failed".

I expect that some users would like to see "failed" so they don't forget to run CI. So I suggest making this part of packit configuration per project.

For example, LGTM is using neutral conclusion.
image image

user-experience

All 10 comments

+1, good suggestion and should be trivial to implement on our side

anyone wants to picks this up on Friday?

The API endpoint we are using for setting commit status does not provide neutral state, only error, failure, pending, or success.

We will need to switch to checks API to be able to use it.

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! :unicorn: :rocket: :robot:

(Note: issues labeled with pinned, security, bug or EPIC are
never marked as stale.)

馃憖

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! :unicorn: :rocket: :robot:

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

Given the fact we are not using the checks API and commit statuses do not support the neutral status, I believe we can close this.

But if we use check API in OGR, we can. (And it should be already implemented in the pygithub.) Not a high-prio, but I would still like to see it.

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! :unicorn: :rocket: :robot:

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

Does it still matter? We require just the namespace to be allowed now.

But we still sometimes want to have some neutral state (e.g. warning during testing-farm problems).

Was this page helpful?
0 / 5 - 0 ratings

Related issues

sentry-io[bot] picture sentry-io[bot]  路  3Comments

jpopelka picture jpopelka  路  5Comments

TomasTomecek picture TomasTomecek  路  5Comments

shreyaspapi picture shreyaspapi  路  9Comments

TomasTomecek picture TomasTomecek  路  6Comments