After examining Ferris wheels (#3550), let's move on to...
(you can't get much bigger:) skyscrapers.
https://en.wikipedia.org/wiki/List_of_tallest_buildings
And what taller than...
And who would guess
Ah, finally at rank fourth do we see something I'm happy with,
Conclusions:
References:
I don’t believe there is a tag for “skyscraper”. You may want to discuss
this on the Tagging mailing list.
How would you suggest to display tall buildings?
We can’t do actual 3D.
We could try to display the name labels at earlier zoom levels, but most
tall buildings are in dense commercial or retail areas with many map
features, so the name of the Empire State Building would might be blocked
by other features.
Icons are normally used for specific tags, and there doesn’t seem to be one
for tall office or mixed-use buildings. As mentioned, we have a tag and
icon for man_made=tower, but whether this can. be used for tall office
buildings is debatable. This could also be discussed at the Tagging mailing
list first.
(We currently render man_made tower at lower zoom levels based on height
because they can be useful for orientation in rural areas. If the tag was
used for many tall buildings on city centres we would probably need to
remove the rendering from z14 and z15)
On Fri, Dec 7, 2018 at 6:49 AM 積丹尼 Dan Jacobson notifications@github.com
wrote:
After examining Ferris wheels (#3550
https://github.com/gravitystorm/openstreetmap-carto/issues/3550), let's
move on to...
(you can't get much bigger:) skyscrapers.
https://en.wikipedia.org/wiki/List_of_tallest_buildings
- The Empire State Building, but who would know?
https://www.openstreetmap.org/way/34633854#map=18/40.74857/-73.98491
You have to zoom to highest zoom level to even see its name.And what taller than...
- https://www.openstreetmap.org/way/137153127#map=19/25.19703/55.27422
"York University"?!?
(Well there is a "BK" there, Burger King one would think.)And who would guess
- https://www.openstreetmap.org/way/165792123
is the second tallest building in the world?
Might as well be some ho-hum one story warehouse in some industrial
district.Ah, finally at rank fourth do we see something I'm happy with,
- https://www.openstreetmap.org/way/535860513
apparently the key is the "tower" tag.Conclusions:
- The mapper people need to use the right tags.
- The right tags (what ever they are) need to be documented.
- Maybe there should be a skyscraper icon, since it is even bigger
than a Ferris wheel.References:
- https://wiki.openstreetmap.org/wiki/Key:building
- https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dtower
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/gravitystorm/openstreetmap-carto/issues/3552, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AoxshF8fix3ckq9qQZFeN47UEHZ6DXEVks5u2ZD7gaJpZM4ZHYYq
.
OSM has 3D tags, and there are maps specialised in 3d-rendering.
This style is a 2D map.
This map style is not focused on showing labels of high objects so it is not issue by itself.
More generally it is really hard to decide whatever building label is more important than amenities inside.
Can you propose any reliable method of checking whatever building name is worth displaying earlier than names of other buildings of a similar footprint?
I don’t believe there is a tag for “skyscraper”. You may want to discuss this on the Tagging mailing list.
I think this is the first step toward different rendering. There are some buildings with such value, but none of them is documented and the usage is very low (28 and 32 respectively) and the problem is that this is not just one:
https://taginfo.openstreetmap.org/tags/building=skyscraper
https://taginfo.openstreetmap.org/tags/building%3Atype=skyscraper
building=skyscraper seems really incorrect.
It is likely that building=office/apartments or other l would be correct (buildings are unlikely to be built just to build a skyscraper).
I thank that better way to find skyscrapers would be to look for building with high value in building:levels tag
But anyway it would be better to discuss it on tagging mailing list.
@jeisenbe, what exactly is the issue with rendering buildings based on height that you referenced above? I might be against it, but it seems like the only practical option. There might be something else like building:levels, but what if the building has only one level but a really tall ceiling, like a cathedral or ampitheater?
I don't think using something like tower/skyscraper would work either. In large cities where there are a lot of skyscrapers their height doesn't automatically make them important.
How would you render them differently?
Use a darker color fill, like places of worship and airport terminals?
Use an icon?
On Fri, Dec 7, 2018 at 1:10 PM Adamant36 notifications@github.com wrote:
@jeisenbe https://github.com/jeisenbe, what exactly is the issue with
rendering buildings based on height that you referenced above? I might be
against it, but it seems like the only practical option. There might be
something else like building:levels, but what if the building has only one
level but a really tall ceiling, like a cathedral or ampitheater?—
You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub
https://github.com/gravitystorm/openstreetmap-carto/issues/3552#issuecomment-445116850,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AoxshA0eEoEI71n28KlYe6NQi0RpbuAwks5u2epJgaJpZM4ZHYYq
.
We shouldn't make any category and special rendering of skyscrapers - as I live in Poland, for me 100m tall building is a skyscraper, but for someone from e.g. Dubai, it would be propably just a regular building. So it would be not clear. Another thing is that if we focus on objects shapes instead of their functions, map would look like this:

All good points @Tomasz-W's makes. Although we already render some things by height. But doing it also with buildings might be a bad idea. Looking over places you would have to start at like 14 or more likely z15 for it work, but normal buildings are already being rendered at those levels. Normal buildings could be removed from z15 and start at z14, but I think it was already discussed and shot down. If its a possibility though, there's still other things to work out. Like the fact that wider, but shorter buildings wouldn't be rendered anymore at z15, Although they might be just as important, because there isn't a comparably width tag. Also it might conflict with how major and minor buildings get rendered. If they ever do.
Instead, different fill color might work like was (is?) being tested for major and minor buildings. Then there could be three different buildings colors, minor=lighter, major=darker, skyscraper(or whatever)=darker then major. That would probably complicate things quit a lot though.
As a side to that, I've tweaking around with different water colors based on the type of water feature. It seems like a good idea and might look good or help mapping, but it introduces some rendering problems I don't think are fixable, and after like 2 variations it gets hard to keep track. I think the issue would happen here. So, in my opinion it would be better just to go with major/minor building rendering based on color shades, include these in there, and leave it at that. Unless there's a better way to do it that I'm not thinking about.
Since there are multiple problems with this proposition, I will close this ticket now. We lack tagging solution first of all, so this should be where it all may start.
At least building names and address numbers should always have priority over the stuff inside (or minor stuff next to, #3435) the building.
This would hide many shops. Not ideal either
That in turn would make objects inside tall objects be always hidden.
Okay, but when should a shop name cause the words Empire State Building to disappear?
The way the code works there's no practical way to make a single exception. You'd either have to display all building names before shops or not There's currently 4.6 million building with the name tag. id guess 99% of those aren't notable. Probably a good number are also miss-tagged. In most cases the name of the building is way less important to the names of the businesses in the building. Let alone displaying building names first would also cover the specific icons. Same goes for addresses.
Okay, but have a look how Google Maps handles the name Empire State Building. Looks great to me, through most if not all zoom levels.
Google Maps doesn't use CartoCSS. So it can handle rendering priority better. Plus, having a team of like 5,000 developers, versus a few volunteers here, probably helps.
Okay, but have a look how Google Maps handles the name Empire State Building. Looks great to me, through most if not all zoom levels.
I agree that in case of Empire State Building label display Google Maps is better. But:
More generally it is really hard to decide whatever building label is more important than amenities inside.
Can you propose any reliable method of checking whatever building name is worth displaying earlier than names of other buildings of a similar footprint?
Google Maps doesn't use CartoCSS. So it can handle rendering priority better.
I think it is rather caused by fact that they have better data to assign importance to labels (for start - full detailed logs of what people searched for using Google).
In this case I get stuck before even starting implemention.
That could be it also.
Okay, but currently all it takes is a few strategically-placed drinking fountains and the name of a building disappears.
Can you provide a link to where that happens? I was just looking at places with water fountains and thinking maybe they could be sent down a level. Some of the issues with things getting in the way of building names could at least be improved by rendering certain things lower.
@Adamant36 Observe the two mirrored C shaped buildings. We note that the right one has its name wiped out thanks to a drinking fountain, whereas, at the same zoom level, the left one is unscathed. We ended up having to make our own map, due to this. Not only water facilities within buildings, but even nearby (#3435), can do damage.
That sucks. It might because the drinking fountains have names that are blocking the other stuff. Especially if they are two lines. As a side note, as far as know things aren't suppose to be named what they are. They aren't suppose to contain descriptions or the type of the item. See https://wiki.openstreetmap.org/wiki/Names "Name is the name only" section.
Most helpful comment
We shouldn't make any category and special rendering of skyscrapers - as I live in Poland, for me 100m tall building is a skyscraper, but for someone from e.g. Dubai, it would be propably just a regular building. So it would be not clear. Another thing is that if we focus on objects shapes instead of their functions, map would look like this: