Openstreetmap-carto: Add rendering for amenity=clock

[Tomasz-W]

https://wiki.openstreetmap.org/wiki/Tag:amenity=clock
Quite popular tag, it has 11,8k uses.

Pole clocks are sometimes used as meeting points; sundials are tourist attraction, but both aren't rendered so they are unvisible on a map.

Icon proposal:

[HolgerJeromin]

We had a PR #2218
With the current setup we are now able to better show important clocks and hide unimportant clocks.
Perhaps use the visiblity=* Tag
ping @jdhoek

[kocio-pl]

Which ones should be visible and from which zoom level?

[jdhoek]

Did something change that will make #2218 possible now? Can we filter on visibility?

[SomeoneElseOSM]

Which ones should be visible and from which zoom level?

I'd definitely show at the very least "sundial" - see e.g. here for an example icon (follow the link in "changelog" there to get to the map style and symbol if needed).

[kocio-pl]

I like the @Tomasz-W proposition, @SomeoneElseOSM proposition is not clear for me (it's rather "angle", for which I couldn't find anything related on the map).

Since v4.0.0 we can use whatever tags we like (without some not display related, like source), because hstore has been introduced and any key which hasn't its own space within database can be used with tags->'key'.

I agree sundials would be useful, what about some other types?

[Tomasz-W]

I'm thinking about excluding small digital clocks like this:
http://l7.alamy.com/zooms/de425e2cb1ed4561bb75b66065ad33c1/digital-platform-clock-victoria-train-station-london-uk-europe-b8adx7.jpg

but at the same time I would like to see big digital clocks like this:
http://stare-neony.pl/pbd2.jpg

Is it technically possible to includedisplay=digital + visibility=area but exclude display=digital with lower visibility=* or without this tag?

I think all allowed clocks should be rendered on zoom 19, but only clocks withvisibility=area should be on zoom 18.

[polarbearing]

Thus, digital or not is not a criterion in my perspective.

[kocio-pl]

I think all allowed clocks should be rendered on zoom 19, but only clocks with visibility=area should be on zoom 18.

Good idea. I think somebody can make a PR any time she thinks everything is clear.

[Tomasz-W]

Gist link: https://gist.github.com/Tomasz-W/07ed36017474669db82b11cb7f64dd26

[james2432]

Do we have an icon digital vs analog or are we just going with the analog version?

[Tomasz-W]

@james2432 Analog version for all types.

[james2432]

what colour should this be? Brown?

[Tomasz-W]

I think man_made-grey would fit there better.

[james2432]

PR Created

[matkoniecz]

Pole clocks are sometimes used as meeting points

amenity=clocks includes rendering for all types of clocks.

sundials are tourist attraction, but both aren't rendered so they are unvisible on a map.

Tourism attractions (at least named ones) are rendered.

[james2432]

Are we requiring sundials to be apart of the pull request or has this discussion been only for clocks?

[Tomasz-W]

I think the PR should include sundials too.

[james2432]

do we have an Icon for it?

[Tomasz-W]

@james2432 No separate icon needed, just use an icon from https://github.com/gravitystorm/openstreetmap-carto/pull/3135#issuecomment-387407378

[james2432]

The PR ever going to get merged then?

[matthijsmelissen]

Closing per https://github.com/gravitystorm/openstreetmap-carto/pull/3135#issuecomment-447722793.

[kocio-pl]

Some helper questions have been just posted, so I think it's better to wait for an answer a bit: https://github.com/gravitystorm/openstreetmap-carto/pull/3135#issuecomment-447745811.

[matkoniecz]

I think that it would be better to open new issue "render prominent amenity=clock" or something similar