Openstreetmap-carto: shop=car_repair color inconsistency dot vs icon

[daganzdaanda]

Hi, just noticed this: For shop=car_repair, as long as it's displayed as just a dot, the color is violet, but when the icon shows up, it is brown.
It seems this is the only shop=* value that is rendered with a brown icon.
It would look better if either the dot for car repairs was brown, or even if there was no dot for this (because we do not use any brown dots atm, IIRC)

Related PRs #2589 and #1778, also discussion #1783 and closed PR #1868

[HolgerJeromin]

I just wanted to report the same. To save my work here are some screenshots :-)

This car_repair can not be fully rendered in every zoom, but is rendered with a pink dot. Bug full icon is brown...
Z17

Z18

[Tomasz-W]

@polarbearing related to #3069

[polarbearing]

I still prefer shop=car, car-repair, bike, bike-repair --> violet

[lakedistrictOSM]

And now there's a name/icon colour mismatch, too:

https://www.openstreetmap.org/way/354086766

[polarbearing]

Just checked, it's on the same tile. But in z19 only, z18 is all brown, z17 is a purple dot.

[jragusa]

Pink icon is not correct since both icon and label are defined in amenity-brown colour. However, I don't understand where is the issue in the code.

[polarbearing]

See discussion about service vs self-service in 3395 .
If we agree on purple than the fix is simply remove the colour-exemption.

[Tomasz-W]

Just for the note: there is the same problem with shop=massage

[jragusa]

Is everyone ok to to use purple colour for shop=car_repair ?

This issue wants desperately to be resolved by a very small fix ;)

[kocio-pl]

I still think that shops should be for selling goods and brown amenities for the places that are selling services, like in this case.

[jragusa]

So what would be the rendering at z17 ? icon or brown dot ?

[kocio-pl]

I would use brown icon with brown label, just like any other service POI. It's easier to stick to the tagging, but hairdresser for example is also not a shop for me, so I would treat it as library or cinema for example.

[Tomasz-W]

brown amenities for the places that are selling services

and leisure-green for places selling leisure-like services (e.g. shop=massage) ;)

[kocio-pl]

Yes - we have more types of services and it's always good to use as specific category as possible.

[jragusa]

If there is no opposition, I will prepare a PR to change purple colour of shop=car_repair and shop=hairdresser to brown amenity colour

[kocio-pl]

I would also check all the other shops we currently render. For example beauty shop is also selling services, but there can be more of such "shops".

[Tomasz-W]

@kocio-pl @jragusa

I've checked shop icons list and I would move to amenity-brown these ones:

• shop=laundry
• shop=dry_cleaning
• shop=car_repair
• shop=hairdresser
• shop=beauty

[HolgerJeromin]

Please use a special color variable
@shop-service or @service-shop
and not
@amenity-brown or @public-service

[dieterdreist]

sent from a phone

On 26. Nov 2018, at 21:48, Tomasz Wójcik [e-mail] wrote:

shop=laundry
shop=dry_cleaning
shop-=car_repair
shop=hairdresser
shop=beauty

like theatres, memorials, archaeological sites, museums and cinemas?

IMHO we should not deviate from the classification that the mappers invented, shops are explicitly selling goods andor services. The above are all clearly shops (they are private businesses), showing them like historic items or cultural places is neither appropriate nor will it facilitate map reading.

[kocio-pl]

like theatres, memorials, archaeological sites, museums and cinemas?

Somebody once asked here in disgust about some POI (I can't remember which one) "why brown, as in toilets?"... Nobody ever reported this (cultural and entertainment having the same color as toilets) as a problem.

We have a gastronomy and health classifications for example, which clearly "deviate" from "amenity", so there's already not a clear color=key rule (with pharmacy being shop, because you buy physical goods, but tagged as amenity...).

[polarbearing]

Traditionally a pharmacy used to prepare your drugs, mix your ointments, thus the perspective as an amenity.

[dieterdreist]

sent from a phone

On 27. Nov 2018, at 02:07, kocio-pl [e-mail] wrote:

Somebody once asked here in disgust about some POI (I can't remember which one) "why brown, as in toilets?"... Nobody ever reported this (cultural and entertainment having the same color as toilets) as a problem.

as long as you follow the osm classification (amenity), it is less of a question, and it is consistent for those knowing the tagging system

We have a gastronomy and health classifications for example, which clearly "deviate" from "amenity", so there's already not a clear color=key rule (with pharmacy being shop, because you buy physical goods, but tagged as amenity...).

“deviating” (splitting a subgroup of things to a new group) also raises less issues, the question is with shifting things from one group into another.
A pharmacy isn’t a simple shop, at least not in Germany or Italy, it is a place where you can get qualified advice by a pharmacist. Other than selling products, they also prepare them (still today, it is not just a historic anecdotal thing).

[jragusa]

So following previous comments I propose to move shop=laundry, shop=dry_cleaning, shop=car_repair, shop=hairdresser and shop=beauty with brown colour of amenity with dedicated variable such as @shop-brown.

Is that ok for everyone ?

[Adamant36]

If the color isn't changing its a superficial change at best. I could see a day when so many things are rendered its better to have variables/colors that aren't tied to the tag types (like with issue #3326). I don't if its at that point yet though. plus there's both advantages and disadvantages. It seems like it will necessary to some degree at some point though.

[jeisenbe]

I haven’t researched this enough to have an opinion, but I suspect there
are other shops that provide services. I’d suggest looking through the
whole list before making changes
On Wed, Nov 28, 2018 at 8:17 PM Adamant36 [e-mail] wrote:

If the color isn't changing its a superficial change at best. I could see
a day when so many things are rendered its better to have variables/colors
that aren't tied to the tag types (like with issue #3326
https://github.com/gravitystorm/openstreetmap-carto/issues/3326). I
don't if its at that point yet though. plus there's both advantages and
disadvantages. It seems like it will necessary to some degree at some point
though.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/gravitystorm/openstreetmap-carto/issues/2658#issuecomment-442411823,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AoxshO83ZmlQEqpjy5lz97oeWK2zIwu9ks5uznDUgaJpZM4N6CI1
.

[Tomasz-W]

@jeisenbe See https://github.com/gravitystorm/openstreetmap-carto/issues/2658#issuecomment-441792517. Please read discussion before you start to participate, otherwise it's a lack of respect for another users and more-or-less their time wasting by discussion messing.

[Tomasz-W]

@kocio-pl As I support moving service-like shops to brown, but at the other hand we won't use brown generic dot (it would be too simillar to gastronomy objects and propably not intuitive) I think that following objects https://github.com/gravitystorm/openstreetmap-carto/issues/2658#issuecomment-441792517 shouldn't be rendered as icons at z17 (they are not so important to show them there, maybe shop=car_repair is an exeption) but since z18.

[kocio-pl]

It's not about importance, for shops and gastronomy it's about their density only. All the other objects don't clutter z17.

[kocio-pl]

For example it was the same with excluding night clubs from gastronomy in #3475.

[jragusa]

Update of the shop variable which would be shifted to amenity brown colour:
shop=laundry
shop=dry_cleaning
shop=car_repair
shop=hairdresser
shop=beauty
shop=travel_agency (new)
amenity=driving_school (edited, new) #4064

[polarbearing]

Wouldn't it be better to move all the daily-life services as above, along with the driving school and crafts, to office-craft-service-blue?

[jeisenbe]

My preference is that the color should patch the key. One of the most important features of this style is mapper feedback, and using the same color for all shop=* values will help mappers to recognize the icon as a type of shop= tag.

[HolgerJeromin]

will help mappers to recognize the icon as a type of shop= tag.

With preset-driven Editors like iD many mappers does not know the keys behind the features.

[jragusa]

In addition there is two colours for amenity key: orange and brown, and we aim to use the same red health colour for healthcare key and some amenities. I add amenity=driving_school to the list.