Openshot-qt: Request for New Target: Chromebook

Created on 3 Mar 2018 · 10Comments · Source: OpenShot/openshot-qt

I was helping out someone recently with some video work and they presentations were at school. Neither of the two projects worked (the audio). The culprit was the chromebooks, which was the standard I believe throughout that entire school system.

So to that end I am requesting to add Chromebook under Device > Target >

using webm VP8 or VP9 for video, and Vorbis for audio as per google support page.

https://support.google.com/chromebook/answer/183093?hl=en

If you like I can submit a diff patch against 2.4.1 or git for it

Thanks,

Gary

💡 enhancement

Source

gary9872

👍1

Most helpful comment

I'm adding the file here in case the pastebin disappears or anything like that. (Note its supposed to be just .xml but for uploading purposes I added the .txt to the end.
chromebook.xml.txt

@peanutbutterandcrackers - I can do a PR for this if you like.

DylanC on 6 Mar 2018

👍2

All 10 comments

@DylanC - I think you should take a look at this. He has made an offer we can not refuse.

@gary9872 - Hey! Thanks! I'm so glad that you are helping OpenShot become a better Video Editor. Please do stick around and help us out with other bugs and stuffs too. We need more developers here. Currently, it's just Mr. Thomas alone. We really appreciate the help. :)

peanutbutterandcrackers on 3 Mar 2018

@gary9872 - If you could submit a PR that would be great! Might take a while to get it reviewed but at least it will get in after a while.

DylanC on 3 Mar 2018

👍1

Yeah! You go, @gary9872 !!! :smile:

peanutbutterandcrackers on 3 Mar 2018

Add to openshot-qt/src/presets directory

chromebook.xml

https://pastebin.com/G6sHeCRh

gary9872 on 6 Mar 2018

@gary9872 - Actually, if you could make a PR, that would probably land you a credit (at least in the git logs) of doing so... Are you sure you do not want to make a PR?

Also, could you please, if you decide to make a PR, take care of #201 ?

Thanks!

peanutbutterandcrackers on 6 Mar 2018

I'm adding the file here in case the pastebin disappears or anything like that. (Note its supposed to be just .xml but for uploading purposes I added the .txt to the end.
chromebook.xml.txt

@peanutbutterandcrackers - I can do a PR for this if you like.

DylanC on 6 Mar 2018

👍2

@DylanC - Well, if @gary9872 does not want to, then please, by all means. :)
Would you like to take care of #201, too, please?

peanutbutterandcrackers on 6 Mar 2018

@peanutbutterandcrackers , @gary9872 - PR added. I should be able to get around to #201 too.

DylanC on 6 Mar 2018

@DylanC - Awesome!

@gary9872 - I hope you stick around and make some PRs too, good sir!
25vxxj