Openshot-qt: Unexpected crash after applying "Time" to any video

[DanPinGF]

System Details:

• Operating System / Distro: Windows 10
• OpenShot Version: 2.4.1
• _Please attach log files if crash_

Issue Description and steps to reproduce:

Every time I speed up a video, OpenShot unexpectedly crashes, which is being caused by a system component (MSVCRT.DLL). Looks like the "Time" feature is broken; it was working earlier before it went nuts.

The bug is only affecting standard accounts; the only way to get pass this is to run the program as an administrator, then ask the owner of that admin account to type in the password for them.

This needs to get fixed right away.

[peanutbutterandcrackers]

@DylanC - Batman! Gotham needs you!!!

[DylanC]

@DanPinGF - Yep, should get sorted!

[DanPinGF]

OK, so in the past, I tried one of these, go get the "Time" feature working back in time:

• Reinstall the app
• Restart the machine
• Choose a better profile (low vid. resolution and frame rate)

Unfortunately, none of these work. I'm assuming there is a problem with its read/write access rights (in that case, if a logged crash report contains the string "Access Denied", then OpenShot should've reported a status of 0xc0000002 STATUS_ACCESS_DENIED rather than 0xc0000005 STATUS_ACCESS_VIOLATION, indicating that this feature requires elevation to continue). This is probably why OpenShot is triggering a fault in the MSVCRT.DLL system file, because the "Time" feature now requires the use of an administrator account. This cannot happen.

I strongly suggest this get fixed right away!

[peanutbutterandcrackers]

@DanPinGF - Thank you for the intel. @N3WWN, perhaps you could also take a look at this, good sir?

[N3WWN]

Sorry, @peanutbutterandcrackers , Windows DLLs are not in my wheelhouse. I wouldn't know where to start.

[peanutbutterandcrackers]

Oh... okay. Thanks anyways!

[DanPinGF]

Great, the issue is still present but more worse in v2.4.2: OpenShot crashes unexpectedly when speeding up (or slowing down) a video even if the software is running in elevated mode, particularly for certain imported videos. Something's not right with OpenShot's internal code. (As such, I'm getting very frustrated!)

Applying "Time" to a video in the timeline crashes OpenShot completely with no error, but is not caused by MSVCRT.DLL rather than just a "StackHash", due to a heap corruption (stated by 0xc0000374 as the error code in the Event Viewer). So this issue is "not resolved".

[DylanC]

@DanPinGF - Yep, its still not resolved. Marked as a bug. Hopefully someone with the time, skills and interest to fix this will help. In the meantime feel free to use something else on Windows. I can let you know if this is fixed in the future.

[DanPinGF]

@DylanC - So it's been tested, and OpenShot unexpectedly misbehaves/crashes when applying 'Time' to a vid? Then it has to do something with the binary code!

[DanPinGF]

The issue is still present since I updated to 2.4.3. Same crash, no other workaround, it's just an error in the code. I'm still running it in elevated mode.

[Curlyawesomeace]

For anyone who might find this useful, I just launched the program and imported 1 file and sped it up as fast as i could, and this was the log file i got from it. Hope it helps!

openshot-qt.log

[ferdnyc]

@Curlyawesomeace

And you're saying OpenShot crashed, when you did that?

There's nothing in the log file to indicate that a crash even happened. We'd probably need a screenshot of the crash dialog or whatever. (Assuming there was one?)

This appears to be a Windows-only issue. I had no trouble importing a video and speeding it up with Time > Fast > Forward > 16X, running on Linux.

[Curlyawesomeace]

@ferdnyc No crash dialog appeared, sadly.

[SuslikV]

@Curlyawesomeace how your "crash" looks like? Not responding state? It seems that you posted log-file after the application restart - not right after the crash, when application not running any more. Can you post new log-file right after the application was stopped?

[DanPinGF]

So far the bug has been present since v2.4.5. And, of course, it's been years sin-- Oh, okay, I discovered one possible cause. The MSVCRT.DLL file is dumped in C:\Program Files\OpenShot Video Editor after installation, and more than likely OpenShot is using an incompatible build of MSVCRT.DLL (v7.0.7601.23403, which is equivalent to Windows 7 SP1, but I'm using Windows 10 May 2020 Update), according to its file description. In comparison, the MSVCRT.DLL in System32 is v7.0.19041.1, which is that of the Windows 10 May 2020 Update. So, OpenShot should be using the System32 MSVCRT.DLL, not the software's own version. Otherwise, the "Time" function causes an access violation error when used.

Now, shall I call the "Time" function a dangerous feature in OpenShot?

[datamyers]

So I have what seems to be almost the exact same issue. I've tried run as admin, but this doesn't work.

My project was working and playing back just fine until I split the video in track 1 so that I could speed up a section to 16x. The video plays (previews) fine up until that point. A few seconds before the sped up section begins, OpenShot freezes for a few moments, then crashes/closes without any errors or notifications. (I am assuming it was buffering the sped up portion, at the time). If I move the playback marker within the sped up portion of the track and hit play, it does the same. Freezes then crashes w/o any indications or errors. If I start playback after the sped up portion, it plays normally. Funny thing is, when I export the file, the MP4 that is produced seems to playback fine, except that everything is sped up after the beginning of the time modified section.

Seeing @DanPinGF's comment, I tried replacing the DLL in the OpenShot directory w/ the one from the Windows/System32 directory, but the same problem occurs. Perhaps it is using the Windows DLL after all, but needs the other one? I'm _not_ going to replace the one in my Windows directory to find out...

Anyway, would be nice to get some support. I tried opening a bug report on the website, but it kept complaining about the size of the log files, even though deleted them and immediately reproduced the issue. BTW, I updated to today's daily build, but it still crashes.

It seems to be related to the preview function in conjunction w/ the Time function.

[DanPinGF]

Okay, so I tried importing an image sequence and used the Time function on it. And surprisingly, OpenShot did not crash.

So it seems like only audio/video files are affected by this bug.

[DanPinGF]

@DylanC Okay, even the "Freeze" and "Freeze & Zoom" features are affected. I'd say OpenShot isn't really stable yet.

[DanPinGF]

@DylanC Alright, now there's another issue involving MSVCRT.DLL, but this time it's the project files. If OpenShot tries to access files from the library that don't exist, upon playing the video it will crash with 0xc0000005.

[DanPinGF]

@DylanC I'm experiencing yet another issue with OpenShot; this time it relates to exporting video. If a video is sped up in the project, and OpenShot tries to export the project, about half-way through it crashes with status 0xc0000374 (which indicates heap corruption) due to ntdll.dll. What's going on here?!

I'm sorry, but I believe OpenShot for Windows is not fully stable yet. Set it back to 'Alpha'.

UPDATE: I think it actually started happening after I updated my graphics driver.

[DylanC]

@DanPinGF - Thanks for the feedback. I'm not very involved with OpenShot at the moment but I'm sure the guys will pick it up.