Openrefine: Wikidata login: form not submitted when pressing Enter key

Created on 15 Oct 2019  路  11Comments  路  Source: OpenRefine/OpenRefine

When pressing the Enter key in the Wikidata login form from the Wikidata extension, one would expect the form to be submitted, which currently does not happen.

bug good first issue wikibase

All 11 comments

Hi! Can I take this one?

@Jataki please!

Having an issue with my computer with no solution date. I'm sorry, but I'll have to leave this issue for others to have the opportunity to contribute. Thanks anyway and I'm so sorry!

Hey, can I take up this issue?

@Bhanu-mbvg sure, it would be great!

@Bhanu-mbvg let me know if you need any help :)

@wetneb How do I recreate Wikidata login form from the Wikidata extension

  • Start OpenRefine
  • Open any project (or create a new one, by opening any table from your computer for instance. In this case, make sure you go beyond the preview stage by clicking "Create project")
  • Click on the Wikidata button in the top right corner
  • Click "Manage Wikidata account"
    This will create the login dialog where the form can be seen.

The HTML for this dialog is stored in extensions/wikidata/module/scripts/dialogs/manage-account-dialog.html.
The Javascript code for this dialog is extensions/wikidata/module/scripts/dialogs/manage-account-dialog.js.

2259 Pull Request has been made.

I resolved the issue using event listener for enter key inside the form
@wetneb can you see the PR

Hey @wetneb , I am still getting the error of form not getting submit on Enter keypress, can you check once?

When trying from the master branch, pressing Enter submits the form both with Firefox and Chromium, for me. Which browser are you using?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

kushthedude picture kushthedude  路  3Comments

ettorerizza picture ettorerizza  路  3Comments

katrinleinweber picture katrinleinweber  路  3Comments

thadguidry picture thadguidry  路  3Comments

davidegiunchidiennea picture davidegiunchidiennea  路  3Comments